Add game-server sidecar APIs for clustered services#35
Closed
VG-prog wants to merge 10 commits into
Closed
Conversation
Add the shared protobuf, generated runtime code, events, GUID helpers, auth identity helpers, and configuration contracts used by clustered gateway, registry, group, guild, matchmaking, and sidecar flows. Tests, local tooling, and broad documentation are intentionally excluded from this upstream-focused scope.
Wire service discovery, map readiness, stale-safe health and metrics observers, degraded game-server health handling, gateway-scoped cleanup, and shared GUID allocation support. Registry and health code now distinguish world-loop degraded state from process or transport death while preserving live map ownership.
Keep world-loop degraded game servers registered for ownership and existing lookups, but mark them as non-admitting so new player placement skips them. Clear the drain state on successful health recovery and fall back to healthy all-map nodes when an assigned owner is degraded.
Route gateway sessions through cluster-aware worldserver selection, native transport handoff, bounded retry/backoff, cross-service event listeners, and client-facing packet rendering for social, group, guild, guild bank, LFG, battleground, arena, mail, channel, and player-state flows.
Extend character, chat, and mail services for clustered realm identity, Real ID/account lookups, channel membership and moderation, crossrealm whisper policy, online-state broadcasts, and arena-team persistence used by gateway routing.
Add clustered group authority for realm-scoped membership, native LFG materialized groups, member-state freshness, latest-state catch-up, receiver-aware fanout, offline cleanup, debug tracing, and persistent group identity support.
Add realm-scoped guild service routing, charter offer/sign/query/signature handling, native petition persistence, guild cache lifecycle, gateway-facing events, and debug logging for same-realm clustered guild workflows.
Add guildserver-owned same-realm guild bank item, money, tab, log, text, split, merge, withdraw-limit, rollback, and idempotency helpers backed by direct MySQL transactions and guidserver item allocation.
Extend matchmaking and mysqlreverseproxy for crossrealm LFG proposal materialization, persistent instance routes, battleground owner placement, arena-team persistence and rated-result handling, character-state listeners, and route-aware SQL interception.
Extend the libsidecar C ABI and Go bridge with grouped member-state events, guild and LFG RPCs, arena-team and item APIs, monitoring/readiness behavior, config loading, and consumer handlers required by the clustered AzerothCore integration.
Author
|
Closing this draft because it was opened from a stacked branch while targeting That replacement PR presents the current integration honestly as one review surface. Sorry for the review noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the game-server sidecar bridge used by AzerothCore integration.
It adds the C ABI and Go bridge surface for clustered group, guild, LFG, arena, item, monitoring, and consumer-handler flows. The sidecar remains the narrow native boundary: AzerothCore calls into it for discrete cluster operations while ToCloud9 services own distributed coordination.
What changed
Why this matters
The sidecar is the contract between native AzerothCore code and ToCloud9. Keeping this bridge explicit makes it possible to review the C ABI separately from the AzerothCore call sites.
Validation
git diff --check origin/master..HEADenv GOCACHE=/tmp/tc9-go-build GOFLAGS=-buildvcs=false go build ./...env GOCACHE=/tmp/tc9-go-build GOFLAGS=-buildvcs=false make install