Fixes #37882 - Remove @theforeman/vendor by MariaAga · Pull Request #10342 · theforeman/foreman

MariaAga · 2024-10-08T15:42:52Z

Depends on #10345 #10239
"Fixes #37904 - move css from vendor to foreman " Does not bread plugins, but this pr does:
Some plugins have "peerDependencies": "@theforeman/vendor" or assume theforeman/vendor will be available from core, this PR removed theforeman/vendor so it will not be available anymore, and their webpack build will fail with:

ERROR in ./components/AnsibleRolesSwitcher/AnsibleRolesSwitcher.scss (../../foreman/node_modules/css-loader/dist/cjs.js!../../foreman/node_modules/sass-loader/dist/cjs.js!./components/AnsibleRolesSwitcher/AnsibleRolesSwitcher.scss)
webpack.1 | Module build failed (from ../../foreman/node_modules/sass-loader/dist/cjs.js):
webpack.1 | Can't find stylesheet to import.
webpack.1 |   ╷
webpack.1 | 1 │ @import '~@theforeman/vendor/scss/variables';
webpack.1 |   │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

and will have this console error:

Uncaught (in promise) Error: Module build failed (from ../../foreman/node_modules/sass-loader/dist/cjs.js):
Can't find stylesheet to import.
  ╷
1 │ @import '~@theforeman/vendor/scss/variables';
  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  ../foreman_ansible/webpack/components/AnsibleRolesSwitcher/AnsibleRolesSwitcher.scss 1:9  root stylesheet

MariaAga · 2024-10-10T14:35:04Z

In this PR we had to update to npm 8 to get the "overrides" attribute in package.json - "Overrides provide a way to replace a package in your dependency tree with another version, or another package entirely. ".
Which we need to pin victory packages that are used in pf4 charts package. before I think because of some vendor magic pf4 used our install victory, and not the one from the pf4 node_modules, but since I'm simplifying things and moving it all to foreman it doesnt work anymore so we need to completely override victory versions, and not just installing an old one.

@theforeman/packaging are we ok to update to NPM 8+?

MariaAga · 2024-11-12T12:05:33Z

@theforeman/packaging are we ok to update to NPM 8+?

ekohl

Not a real review, but I'd prefer to wrap up https://community.theforeman.org/t/drop-debian-11-ruby-2-7-and-nodejs-14-support-in-foreman-3-14/40503 first. Once we drop NodeJS 14 we should get NPM 8 or higher out of the box on all our supported platforms and that simplifies this PR.

Edit: for completeness, the NPM versions in packaging:

EL9 with NodeJS 18: 10.2.4 (dnf module enable nodejs:18 && dnf install npm)
Debian 12 with NodeJS 17: 9.2.0 (https://packages.debian.org/bookworm/npm)
Ubuntu 22.04: TODO (OS repo has NodeJS 12 so we use nodesource; 14 at the moment)

ekohl · 2024-12-19T14:16:05Z

@theforeman/packaging are we ok to update to NPM 8+?

When we merge #10406 it should be something we get for free.

MariaAga · 2025-03-10T11:12:48Z

Moved to a react page anyway

MariaAga · 2025-03-10T11:17:16Z

move to window directly, not under tfm

MariaAga · 2025-03-10T11:26:17Z

dnd still not working in host edit with vm ware - need to fix
edit: https://projects.theforeman.org/issues/37882

MariaAga · 2025-04-04T13:31:43Z

Probably not needed https://developer.mozilla.org/en-US/docs/Web/API/Web_components#browser_compatibility

ShimShtein · 2025-07-08T12:44:31Z

Packaging status:

first set of packages Add first round of packages previously vendored inside @theforeman/vendor foreman-packaging#12145
second set of packages Add second round of packages previously vendored inside @theforeman/vendor foreman-packaging#12174
Reqs Update reqs for Remove @theforeman/vendor foreman-packaging#12157

ShimShtein · 2025-07-09T16:12:41Z

@MariaAga seems unrelated, but can you make sure it's OK: https://github.com/theforeman/foreman/actions/runs/16148221131/job/45572685027?pr=10342#step:16:728

MariaAga · 2025-07-09T16:24:45Z

@ShimShtein it is unrelated (org tests just randomly fail)

evgeni · 2025-07-10T09:14:41Z

/packit build

evgeni · 2025-07-10T09:28:49Z

ModuleNotFoundError: Module not found: Error: Can't resolve 'react-bootstrap' in '/usr/lib/node_modules/react-ellipsis-with-tooltip/dist'

Mhh, react-bootstrap is a peerDependency of react-ellipsis-with-tooltip, and our packaging doesn't pull those in.

MariaAga · 2025-07-10T09:30:29Z

@evgeni

Mhh, react-bootstrap is a peerDependency of react-ellipsis-with-tooltip, and our packaging doesn't pull those in.

is this a hint for me to add it?

evgeni · 2025-07-10T09:31:27Z

not yet :)

evgeni · 2025-07-10T09:34:21Z

    "datatables.net-bs": "1.13.5",
+    "datatables.net-dt": "1.13.5",
+    "datatables.net": "1.13.5",
+    "diff": "^4.0.1",


theforeman/foreman-packaging#12212 bumped the packaged diff to 5.2.0, can we do the same here?

I'll go check if we can use v5

@MariaAga , I have matched the diff version to unidiff 1.0.4

Actually cant find where we even use diff?

I think the last use was here? 0b167ac#diff-9bfb62f05186261a2516e33d3b97b39947316f570fde17c8cd91f32f99d51835
So I guess I can just update now and delete later

evgeni · 2025-07-10T09:39:09Z

#10601 - let's see if adding react-bootstrap helps.

Edit:

[webpack-cli] ModuleNotFoundError: Module not found: Error: Can't resolve 'react-router' in '/usr/lib/node_modules/connected-react-router/esm'

Well, at least it's a different error now? 😿

evgeni · 2025-07-10T12:13:37Z

@MariaAga okay, now that #10601 has built on packit: please pull in the react-router and react-bootstrap changes I did into package.json.

I have no idea if it also needs to be added to webpack.js -- seems to work without as long as the peer dependency is satisfied.

Packaging update:

Update NPM dependencies foreman-packaging#12221

and seperate javascript and react app imports

MariaAga · 2025-07-10T13:50:14Z

no runtime error for not adding react-router and react-bootstrap to webpack vendor list

evgeni · 2025-07-10T17:17:44Z

/packit build

evgeni · 2025-07-10T17:26:21Z

green packit! 🍏

evgeni · 2025-07-11T09:37:01Z

Ubuntu 22.04: TODO (OS repo has NodeJS 12 so we use nodesource; 14 at the moment)

NodeJS 18.20.6 with NPM 10.8.2

evgeni

📦 wise this is fine and I have no concerns, especially as Packit is green

ShimShtein

I won't block on these

ShimShtein · 2025-07-14T09:08:57Z

+          __dirname,
+          '..',


Suggested change

__dirname,

'..',

root,

then in the next pr (scalprum)

ShimShtein · 2025-07-14T09:09:19Z

+          __dirname,
+          '..',


Suggested change

__dirname,

'..',

root

pr-processor Bot added the Not yet reviewed label Oct 8, 2024

github-actions Bot added UI Legacy JS PRs making changes in the legacy Javascript stack Docs labels Oct 8, 2024

MariaAga commented Oct 9, 2024

View reviewed changes

Comment thread webpack/assets/javascripts/react_app/common/helpers.js Outdated

pr-processor Bot removed the Not yet reviewed label Oct 9, 2024

MariaAga commented Oct 9, 2024

View reviewed changes

Comment thread app/views/layouts/base.html.erb Outdated

MariaAga commented Oct 10, 2024

View reviewed changes

Comment thread package.json Outdated

MariaAga mentioned this pull request Oct 10, 2024

Fixes #37904 - move css from vendor to foreman #10345

Merged

MariaAga force-pushed the remove-foreman-vendor branch 2 times, most recently from d48bcac to 005f580 Compare October 30, 2024 16:54

ekohl reviewed Dec 19, 2024

View reviewed changes

MariaAga commented Mar 10, 2025

View reviewed changes

Comment thread app/assets/javascripts/application.js Outdated

MariaAga Mar 10, 2025

Copy link
Copy Markdown

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to a react page anyway

MariaAga commented Mar 10, 2025

View reviewed changes

MariaAga force-pushed the remove-foreman-vendor branch from 005f580 to 6fbd51d Compare April 2, 2025 12:09

MariaAga commented Apr 2, 2025

View reviewed changes

Comment thread package.json Outdated

MariaAga force-pushed the remove-foreman-vendor branch from 6fbd51d to 51e67a1 Compare April 4, 2025 10:42

MariaAga commented Apr 4, 2025

View reviewed changes

Comment thread config/webpack.vendor.js Outdated

MariaAga force-pushed the remove-foreman-vendor branch from 51e67a1 to b6a647e Compare April 4, 2025 15:31

ekohl reviewed Apr 8, 2025

View reviewed changes

Comment thread webpack/assets/javascripts/exportAll.js Outdated

MariaAga commented Apr 8, 2025

View reviewed changes

Comment thread package.json Outdated

MariaAga force-pushed the remove-foreman-vendor branch from b6a647e to 785ab7e Compare April 10, 2025 13:52

MariaAga added the Breaking change This PR may break plugins - maintainers try to apply it as best effort label Apr 15, 2025

MariaAga commented May 14, 2025

View reviewed changes

Comment thread webpack/assets/javascripts/react_app/common/scss/vendor-core.scss Outdated

MariaAga assigned ShimShtein May 14, 2025

This was referenced Jul 1, 2025

Fixes #37908 - move css import from vendor to foreman theforeman/foreman-tasks#770

Merged

Fixes #37910 - move css import from vendor to foreman Katello/katello#11429

Merged

MariaAga commented Jul 8, 2025

View reviewed changes

Comment thread config/webpack.config.js Outdated

MariaAga force-pushed the remove-foreman-vendor branch from 57ba564 to 01cee4f Compare July 8, 2025 15:55

MariaAga mentioned this pull request Jul 9, 2025

Fixes #38570 - adding scalprum to shared webpack #10598

Merged

evgeni reviewed Jul 10, 2025

View reviewed changes

Comment thread package.json Outdated

MariaAga force-pushed the remove-foreman-vendor branch from 01cee4f to 8c47a76 Compare July 10, 2025 09:29

evgeni reviewed Jul 10, 2025

View reviewed changes

nofaralfasi mentioned this pull request Jul 10, 2025

Fixes #38560 - Upgrade react-router-dom from v5 to v6 #10602

Closed

MariaAga force-pushed the remove-foreman-vendor branch from 8c47a76 to 92da380 Compare July 10, 2025 11:48

Fixes #37882 - Remove @theforeman/vendor

4012727

and seperate javascript and react app imports

MariaAga force-pushed the remove-foreman-vendor branch from 92da380 to 4012727 Compare July 10, 2025 13:49

evgeni approved these changes Jul 11, 2025

View reviewed changes

ShimShtein approved these changes Jul 14, 2025

View reviewed changes

ShimShtein merged commit 8afe2c4 into theforeman:develop Jul 14, 2025
59 of 65 checks passed

MariaAga mentioned this pull request Jul 25, 2025

Fixes #37909 - move css import from vendor to foreman theforeman/foreman_leapp#158

Merged

MariaAga mentioned this pull request Jan 16, 2026

Add nodejs-patternfly-react-templates package theforeman/foreman-packaging#12902

Merged

Uh oh!

Conversation

MariaAga commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MariaAga commented Oct 10, 2024

Uh oh!

MariaAga commented Nov 12, 2024

Uh oh!

ekohl left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ekohl commented Dec 19, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MariaAga commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShimShtein commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ShimShtein commented Jul 9, 2025

Uh oh!

MariaAga commented Jul 9, 2025

Uh oh!

evgeni commented Jul 10, 2025

Uh oh!

Uh oh!

evgeni commented Jul 10, 2025

Uh oh!

MariaAga commented Jul 10, 2025

Uh oh!

evgeni commented Jul 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evgeni commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evgeni commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MariaAga commented Jul 10, 2025

Uh oh!

evgeni commented Jul 10, 2025

Uh oh!

evgeni commented Jul 10, 2025

Uh oh!

evgeni commented Jul 11, 2025

Uh oh!

evgeni left a comment

Choose a reason for hiding this comment

Uh oh!

ShimShtein left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

MariaAga commented Oct 8, 2024 •

edited

Loading

ekohl left a comment •

edited

Loading

MariaAga commented Mar 10, 2025 •

edited

Loading

ShimShtein commented Jul 8, 2025 •

edited

Loading

evgeni commented Jul 10, 2025 •

edited

Loading

evgeni commented Jul 10, 2025 •

edited

Loading