Add nodejs-patternfly-react-templates package by MariaAga · Pull Request #12902 · theforeman/foreman-packaging

MariaAga · 2026-01-07T16:17:53Z

ogajduse · 2026-01-14T14:19:43Z

[2026-01-07T16:29:27.560Z]         Error: Repoclosure ended with unresolved dependencies (2) across 2 packages.

[2026-01-07T16:29:27.560Z]         package: foreman-3.18.0-0.3.develop.el9.noarch from el9-foreman-nightly-staging

[2026-01-07T16:29:27.560Z]           unresolved deps (1):

[2026-01-07T16:29:27.560Z]             (rubygem(dynflow) >= 1.6.5 with rubygem(dynflow) < 2.0.0)

[2026-01-07T16:29:27.560Z]         package: foreman-assets-3.18.0-0.4.develop.el9.noarch from repo0

[2026-01-07T16:29:27.560Z]           unresolved deps (1):

[2026-01-07T16:29:27.560Z]             (npm(@patternfly/react-templates) >= 1.1.8 with npm(@patternfly/react-templates) < 2.0.0)

I'd say repoclosure error with (npm(@patternfly/react-templates) >= 1.1.8 with npm(@patternfly/react-templates) < 2.0.0) is expected.

But I am unsure about (rubygem(dynflow) >= 1.6.5 with rubygem(dynflow) < 2.0.0).

Anyone from @theforeman/packaging mind chiming in?

ogajduse · 2026-01-14T14:20:21Z

@MariaAga, your patch needs to be rebased due to new changes in foreman.spec.

adamruzicka · 2026-01-14T14:23:32Z

But I am unsure about (rubygem(dynflow) >= 1.6.5 with rubygem(dynflow) < 2.0.0).

A rebase should make that go away

MariaAga · 2026-01-14T15:12:08Z

rebased

ogajduse · 2026-01-14T15:47:25Z

But I am unsure about (rubygem(dynflow) >= 1.6.5 with rubygem(dynflow) < 2.0.0).

A rebase should make that go away

It indeed went away. ACK on behalf of packaging. Not sure about the timing of the merge, so I'd leave merging up to you, Maria.

adamruzicka

I'd be curious where the npm(diff) thing came from. Left some minor comments here and there, but in general this should be good to go

adamruzicka · 2026-01-16T09:34:03Z

 Requires: (npm(react-dnd) >= 14.0.2 with npm(react-dnd) < 15.0.0)
 Requires: (npm(react-dnd-html5-backend) >= 14.0.0 with npm(react-dnd-html5-backend) < 15.0.0)
 Requires: (npm(react-dom) >= 16.8.1 with npm(react-dom) < 17.0.0)
-Requires: (npm(react-ellipsis-with-tooltip) >= 1.0.8 with npm(react-ellipsis-with-tooltip) < 2.0.0)


note: Removed in theforeman/foreman@68c236f

adamruzicka · 2026-01-16T09:34:25Z

 Requires: (npm(rc-input-number) >= 6.0.0 with npm(rc-input-number) < 7.0.0)
 Requires: (npm(react) >= 16.9.0 with npm(react) < 17.0.0)
 Requires: (npm(react-ace) >= 9.5.0 with npm(react-ace) < 10.0.0)
-Requires: (npm(react-bootstrap) >= 0.32.0 with npm(react-bootstrap) < 1.0.0)


note: Removed in theforeman/foreman@38fecf3

adamruzicka · 2026-01-16T09:34:57Z

-Requires: (npm(regenerator-runtime) >= 0.13.3 with npm(regenerator-runtime) < 1.0.0)
+Requires: npm(regenerator-runtime) = 0.14.1


note: Pinned in theforeman/foreman@d2dc1d9

adamruzicka · 2026-01-16T09:36:36Z

-Requires: (npm(diff) >= 5.1.0 with npm(diff) < 6.0.0)
+Requires: npm(diff) = 5.2.0


Where is this coming from?

theforeman/foreman#10342

Ah, thank you

adamruzicka · 2026-01-16T09:37:46Z

+%{?scl:%scl_package nodejs-%{npm_name}}
+%{!?scl:%global pkg_name %{name}}


We do not use scl anymore. It does not hurt anything, but it is dead code. Assuming the spec was generated from our templates, I'd be willing to let it slide.

I ran ./update-requirements npm "../foreman/package.json" "./packages/foreman/foreman/foreman.spec"

Adam, seems you have a context about SCL usage. Would you mind creating an issue in this project to remove it from our specs and the template(s)?

https://projects.theforeman.org/issues/39003

Redmine is better, of course. :) Thank you!

MariaAga requested a review from a team as a code owner January 7, 2026 16:17

pr-processor Bot added Not yet reviewed RPM labels Jan 7, 2026

Add nodejs-patternfly-react-templates package

f5236b1

MariaAga force-pushed the react-templates branch from c6964de to f5236b1 Compare January 14, 2026 15:09

ogajduse approved these changes Jan 14, 2026

View reviewed changes

pr-processor Bot removed the Not yet reviewed label Jan 14, 2026

adamruzicka approved these changes Jan 16, 2026

View reviewed changes

adamruzicka mentioned this pull request Jan 16, 2026

Fixes #38978 - Add @patternfly/react-templates theforeman/foreman#10811

Merged

ogajduse merged commit ee33281 into theforeman:rpm/develop Jan 16, 2026
3 of 4 checks passed

		Requires: (npm(regenerator-runtime) >= 0.13.3 with npm(regenerator-runtime) < 1.0.0)
		Requires: npm(regenerator-runtime) = 0.14.1

		Requires: (npm(diff) >= 5.1.0 with npm(diff) < 6.0.0)
		Requires: npm(diff) = 5.2.0

		%{?scl:%scl_package nodejs-%{npm_name}}
		%{!?scl:%global pkg_name %{name}}

Uh oh!

Conversation

MariaAga commented Jan 7, 2026

Uh oh!

ogajduse commented Jan 14, 2026

Uh oh!

ogajduse commented Jan 14, 2026

Uh oh!

adamruzicka commented Jan 14, 2026

Uh oh!

MariaAga commented Jan 14, 2026

Uh oh!

ogajduse commented Jan 14, 2026

Uh oh!

adamruzicka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants