Fixes #38978 - Add @patternfly/react-templates - #10811
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds the @patternfly/react-templates package (version ^1.1.8) to simplify the usage of PatternFly components by providing wrapped components with streamlined APIs. The PR also updates all PatternFly React packages from version ^5.2.0 to versions in the 5.4.x range to ensure compatibility with react-templates.
Key Changes:
- Added
@patternfly/react-templatesdependency to provide simplified component wrappers - Updated PatternFly React packages from v5.2.x to v5.4.x for compatibility and to get latest features
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@patternfly/react-table": "^5.2.0", | ||
| "@patternfly/react-tokens": "^5.2.0", | ||
| "@patternfly/react-core": "^5.4.8", | ||
| "@patternfly/react-icons": "^5.4.2", |
There was a problem hiding this comment.
The version ^5.4.2 is specified for @patternfly/react-icons, but @patternfly/react-core and @patternfly/react-table are using ^5.4.8. To ensure consistency and compatibility across PatternFly packages, consider updating this to ^5.4.8 to match the other react packages.
| "@patternfly/react-icons": "^5.4.2", | |
| "@patternfly/react-icons": "^5.4.8", |
There was a problem hiding this comment.
Latest version is @patternfly/react-icons: 5.4.2
|
I see the |
|
" The idea is that the packaging team will be added to any changes to dependencies. |
That matches how I view it. Then it is ACK on behalf of packaging. |
adamruzicka
left a comment
There was a problem hiding this comment.
Packit fails due to a dependency not being available, but that is expected until theforeman/foreman-packaging#12902 goes in.
All the bumped versions are already present in rpm/develop at the required (or higher) versions.
|
Thank you @MariaAga ! |
Updated the required PF5 version to include a version that supports react-templates and is the latest.
"This package provides wrapped Patternfly component demos with a streamlined API for ease of use."
I want to add it so we can use a simple version of Select (and other components) instead of creating our own wrappers
With the package:
Without (need to specify a full toggle components and more):