Fixes #38560 - Upgrade react-router-dom from v5 to v6 - #10602
Closed
nofaralfasi wants to merge 2 commits into
Closed
Fixes #38560 - Upgrade react-router-dom from v5 to v6#10602nofaralfasi wants to merge 2 commits into
nofaralfasi wants to merge 2 commits into
Conversation
and seperate javascript and react app imports
Member
|
This also happens on CVEList components |
Member
|
@nofaralfasi, needs rebase |
Contributor
Author
I'm not sure if we'll end up using this PR. The Insights team is working on downgrading react-router-dom to v5 on their side. |
Contributor
Author
|
Closing this PR, as it's no longer needed - the Insights team is working on downgrading react-router-dom to v5 on their side, so we can keep using v5 for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #10342
Required for theforeman/foreman_rh_cloud#1019
This change is needed because https://github.com/RedHatInsights/landing-page-frontend rely on
react-router-dom@6features likeuseSearchParams, which are incompatible with the older v5 routing context, causing runtime errors.