Fixes #37904 - move css from vendor to foreman - #10345
Conversation
c7acb7d to
2f6ac72
Compare
2f6ac72 to
85b1beb
Compare
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
The failure:
Capybara::ElementNotFound: Unable to find visible css "#ms-domain_location_ids .ms-selectable"
Have you looked at this?
There was a problem hiding this comment.
Wasnt there before and looks like one of the randomly failing tests, re running it and will check it, thanks! |
|
re-ran the tests and now its not failing |
ShimShtein
left a comment
ShimShtein
left a comment
There was a problem hiding this comment.
Created a packaging PR.
@ekohl do we want to merge the packaging PR first and then make sure packit is working correctly?
There was a problem hiding this comment.
|
Packit needs an updated foreman.spec to pull in the new dep, so it will never¹ work in this PR and I think that's OK? ¹: you could have a prepared branch for updating foreman.spec in foreman-packaging and update packit to use that spec file for showing it works, and then reverting back to the vanilla one for the merge. |
|
Sounds like too much trouble and too error prone. |
85b1beb to
3275089
Compare
|
Please rebase this one |
3275089 to
73c1f5a
Compare
73c1f5a to
f3c5055
Compare
|
/packit build |
|
Oh, I'm stupid. That still will fail, as there is no |
4 participants
One of the steps for removing foreman-js vendor is moving the css into foreman. (#10342).
This PR is not a breaking change, removing theforeman/vendor will be a breaking change.
I will also open PRs for all plugins I found (Ansible,Remote Execution ,Templates,foreman-tasks,Katello,Leapp )
This PR also includes packages/vendor-core/scss/vendor-core.scss and building it in webpack from foreman core instead of building it in webpack 4 in foreman-js