RDKEMW-14686: Wifi DataModel Params Retuning Empty Value on RDKE Builds by Vismalskumar0 · Pull Request #399 · rdkcentral/tr69hostif

Vismalskumar0 · 2026-03-12T05:41:28Z

No description provided.

Copilot

Pull request overview

Updates the WiFi SSID profile implementation to populate the TR-069 Name field from the Thunder JSON-RPC GetConnectedSSID response.

Changes:

Adds a JSON validation guard around assigning name from the ssid field.
Adds an error log when the JSON payload is missing/invalid for ssid.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-12T08:57:08Z

@Vismalskumar0 I've opened a new pull request, #400, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-03-12T08:57:41Z

@Vismalskumar0 I've opened a new pull request, #401, to work on those changes. Once the pull request is ready, I'll request review from you.

…SID.cpp Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>

Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>

Fix always-true `response.c_str()` guards in Device_WiFi_SSID RPC response handling

Fix inconsistent indentation in Device_WiFi_SSID.cpp interface-parsing block

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-12T10:52:24Z

@Vismalskumar0 I've opened a new pull request, #405, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>

Fix misleading "curl init failed" error log in Device_WiFi_SSID.cpp

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Vismalskumar0 · 2026-03-12T11:05:31Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-03-12T11:05:39Z

@Vismalskumar0 I've opened a new pull request, #406, to work on those changes. Once the pull request is ready, I'll request review from you.

…n GetWifiState Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>

…0ca-40d1-95d2-38f429faca17 Guard against null dereference on missing/non-numeric "state" field in GetWifiState JSON parsing

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-12T11:23:17Z

@Vismalskumar0 I've opened a new pull request, #407, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/hostif/profiles/wifi/Device_WiFi_SSID.cpp:422

The switch (res) over WiFi state has no default case. If NetworkManager ever returns an unexpected/extended state value, status (and rc) may remain unchanged from a previous call, leading to stale/incorrect TR-181 Status reporting. Add a default branch that sets a safe value (e.g., "ERROR") and ensures rc is assigned before checking rc != EOK.

                    switch (res) {
			case 0:
			    rc=strcpy_s(status,sizeof(status),"UNINSTALLED");
			    break;
			case 1:
			    rc=strcpy_s(status,sizeof(status),"DISABLED");
			    break;
			case 2:
			    rc=strcpy_s(status,sizeof(status),"DISCONNECTED");
			    break;
			case 3:
		            rc=strcpy_s(status,sizeof(status),"PAIRING");
			    break;
			case 4:
			    rc=strcpy_s(status,sizeof(status),"CONNECTING");
			    break;
			case 5:
			    rc=strcpy_s(status,sizeof(status),"CONNECTED");
			    break;
			case 6:
			    rc=strcpy_s(status,sizeof(status),"SSID_NOT_FOUND");
			    break;
			case 7:
			    rc=strcpy_s(status,sizeof(status),"SSID_CHANGED");
			    break;
			case 8:
			    rc=strcpy_s(status,sizeof(status),"CONNECTION_LOST");
			    break;
			case 9:
			    rc=strcpy_s(status,sizeof(status),"CONNECTION_FAILED");
			    break;
			case 10:
			    rc=strcpy_s(status,sizeof(status),"CONNECTION_INTERRUPTED");
			    break;
			case 11:
			    rc=strcpy_s(status,sizeof(status),"INVALID_CREDENTIALS");
			    break;
			case 12:
			    rc=strcpy_s(status,sizeof(status),"AUTHENTICATION_FAILED");
			    break;
			case 13:
			    rc=strcpy_s(status,sizeof(status),"ERROR");
			    break;
			}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Update Device_WiFi_SSID.cpp

ea3a69d

Vismalskumar0 requested a review from a team as a code owner March 12, 2026 05:41

Copilot AI review requested due to automatic review settings March 12, 2026 05:41

Copilot started reviewing on behalf of Vismalskumar0 March 12, 2026 05:41 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Comment thread src/hostif/profiles/wifi/Device_WiFi_SSID.cpp Outdated

Comment thread src/hostif/profiles/wifi/Device_WiFi_SSID.cpp Outdated

Update Device_WiFi_SSID.cpp

3c1b28b

Copilot AI review requested due to automatic review settings March 12, 2026 06:26

Copilot started reviewing on behalf of Vismalskumar0 March 12, 2026 06:26 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Comment thread src/hostif/profiles/wifi/Device_WiFi_SSID.cpp Outdated

Vismalskumar0 added 2 commits March 12, 2026 14:05

Update Device_WiFi_EndPoint.cpp

c8f69ab

Update Device_WiFi_SSID.cpp

3730abf

Copilot AI review requested due to automatic review settings March 12, 2026 08:41

Copilot started reviewing on behalf of Vismalskumar0 March 12, 2026 08:41 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Comment thread src/hostif/profiles/wifi/Device_WiFi_SSID.cpp Outdated

Comment thread src/hostif/profiles/wifi/Device_WiFi_SSID.cpp

Update src/hostif/profiles/wifi/Device_WiFi_SSID.cpp

a7cb7e7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 12, 2026 08:53

Copilot started reviewing on behalf of Vismalskumar0 March 12, 2026 08:53 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Comment thread src/hostif/profiles/wifi/Device_WiFi_SSID.cpp Outdated

Initial plan

edda013

Copilot AI mentioned this pull request Mar 12, 2026

Fix always-true response.c_str() guards in Device_WiFi_SSID RPC response handling #400

Merged

Initial plan

695abe4

Copilot AI mentioned this pull request Mar 12, 2026

Fix inconsistent indentation in Device_WiFi_SSID.cpp interface-parsing block #401

Merged

Copilot AI and others added 4 commits March 12, 2026 09:00

Fix response.c_str() checks to use !response.empty() in Device_WiFi_S…

ffca495

…SID.cpp Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>

Fix inconsistent indentation in Device_WiFi_SSID.cpp parsing block

da16047

Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>

Merge pull request #400 from rdkcentral/copilot/sub-pr-399

3beeec2

Fix always-true `response.c_str()` guards in Device_WiFi_SSID RPC response handling

Merge pull request #401 from rdkcentral/copilot/sub-pr-399-again

1d45233

Fix inconsistent indentation in Device_WiFi_SSID.cpp interface-parsing block

Copilot AI review requested due to automatic review settings March 12, 2026 09:44

Copilot started reviewing on behalf of Vismalskumar0 March 12, 2026 09:44 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Initial plan

2f2043e

Copilot AI mentioned this pull request Mar 12, 2026

Fix misleading "curl init failed" error log in Device_WiFi_SSID.cpp #405

Merged

Copilot AI and others added 2 commits March 12, 2026 10:56

Fix misleading "curl init failed" error log to "getJsonRPCData() failed"

67e4d57

Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>

Merge pull request #405 from rdkcentral/copilot/sub-pr-399-please-work

2d0e71b

Fix misleading "curl init failed" error log in Device_WiFi_SSID.cpp

Vismalskumar0 requested a review from Copilot March 12, 2026 10:59

Copilot started reviewing on behalf of Vismalskumar0 March 12, 2026 11:00 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Initial plan

147404e

Copilot AI mentioned this pull request Mar 12, 2026

Guard against null dereference on missing/non-numeric "state" field in GetWifiState JSON parsing #406

Merged

Copilot AI and others added 2 commits March 12, 2026 11:10

Add null and type check for state cJSON item before valueint access i…

58bd5a1

…n GetWifiState Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>

Merge pull request #406 from rdkcentral/copilot/sub-pr-399-99188a72-8…

7240484

…0ca-40d1-95d2-38f429faca17 Guard against null dereference on missing/non-numeric "state" field in GetWifiState JSON parsing

Vismalskumar0 requested a review from Copilot March 12, 2026 11:17

Copilot started reviewing on behalf of Vismalskumar0 March 12, 2026 11:18 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Comment thread src/hostif/profiles/wifi/Device_WiFi_SSID.cpp

Comment thread src/hostif/profiles/wifi/Device_WiFi_SSID.cpp Outdated

Copilot AI mentioned this pull request Mar 12, 2026

Fix misleading error logs for empty/failed JSON-RPC responses in Device_WiFi_SSID #407

Open

Update Device_WiFi_SSID.cpp

0c2e924

nhanasi approved these changes Mar 12, 2026

View reviewed changes

nhanasi changed the title ~~Update Device_WiFi_SSID.cpp~~ RDKEMW-14686: Wifi DataModel Params Retuning Empty Value on RDKE Builds Mar 12, 2026

AravindanNC approved these changes Mar 12, 2026

View reviewed changes

Merge branch 'develop' into feature/RDKEMW-14686_final

07c9fe0

Copilot AI review requested due to automatic review settings March 12, 2026 17:56

Copilot started reviewing on behalf of nhanasi March 12, 2026 17:56 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

nhanasi merged commit 3319ef4 into develop Mar 12, 2026
16 checks passed

github-actions Bot locked and limited conversation to collaborators Mar 12, 2026

Uh oh!

Conversation

Vismalskumar0 commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI commented Mar 12, 2026

Uh oh!

Copilot AI commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Vismalskumar0 commented Mar 12, 2026

Uh oh!

Copilot AI commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants