Guard against null dereference on missing/non-numeric "state" field in GetWifiState JSON parsing - #406
Merged
Vismalskumar0 merged 2 commits intoMar 12, 2026
Conversation
…n GetWifiState Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Device_WiFi_SSID.cpp
Guard against null dereference on missing/non-numeric "state" field in GetWifiState JSON parsing
Mar 12, 2026
Vismalskumar0
marked this pull request as ready for review
March 12, 2026 11:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing
state->valueintin theGetWifiStateblock had no null or type check — if the JSON response omitted"state"or returned it as a non-numeric type, the code would dereference a null pointer.Changes
Device_WiFi_SSID.cpp: Added!state || !cJSON_IsNumber(state)guard immediately aftercJSON_GetObjectItem(jsonObj, "state"), before any access tostate->valueint. ReturnsNOKwith an error log on failure.Consistent with the validation pattern used for
"state"inDevice_WiFi_EndPoint.cpp.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.