Fix misleading error logs for empty/failed JSON-RPC responses in Device_WiFi_SSID - #407
Open
Vismalskumar0 with Copilot wants to merge 1 commit into
Open
Conversation
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on Device_WiFi_SSID.cpp update
Fix misleading error logs for empty/failed JSON-RPC responses in Device_WiFi_SSID
Mar 12, 2026
Vismalskumar0
marked this pull request as ready for review
March 12, 2026 11:27
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
elsebranches handling empty/failedgetJsonRPCData()responses were logging"curl init failed", which was inaccurate — curl may have succeeded but returned an empty or unparseable response.Changes
GetConnectedSSID: Replaced theif (!response.empty())guard with an explicit early-exit pattern:GetAvailableInterfaces/GetWifiState: Replaced"curl init failed"in theelsebranches with"getJsonRPCData() failed"to accurately reflect the actual failure point.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.