Fix inconsistent indentation in Device_WiFi_SSID.cpp interface-parsing block - #401
Merged
Vismalskumar0 merged 2 commits intoMar 12, 2026
Merged
Conversation
Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on Device_WiFi_SSID.cpp updates
Fix inconsistent indentation in Device_WiFi_SSID.cpp interface-parsing block
Mar 12, 2026
Vismalskumar0
marked this pull request as ready for review
March 12, 2026 09:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface-parsing block in
Device_WiFi_SSID.cpp(~lines 277–340) mixed tabs and spaces with misaligned nesting levels, making the control flow hard to follow and error-prone to modify.Changes
forand innerifblocks onto their own lines, matching the surrounding code styleif (!cJSON_IsArray),for (...), innerif (!cJSON_IsObject),if (strcmp(...WIFI...)), post-loop checks) is now visually distinctBefore:
After:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.