Consolidate type schema validation and conformance gates#271
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev/2026-07-28-rc #271 +/- ##
=====================================================
+ Coverage 84.47% 84.75% +0.27%
=====================================================
Files 69 70 +1
Lines 12098 15364 +3266
=====================================================
+ Hits 10220 13022 +2802
- Misses 1878 2342 +464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jun 1, 2026
c9bdfa7 to
017b707
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JsonObjectparse/serialize round-trips so officialjson-schema-2020-12coverage stays wire-compatibleReviewer Map
lib/src/types/*,lib/src/shared/json_schema/*,lib/src/types/elicitation.dart,lib/src/types/json_rpc.dartlib/src/client/*,lib/src/server/*,lib/src/shared/protocol.darttest/conformance/*.github/workflows/test_core.yml,test/conformance/README.md,CHANGELOG.mdtest/mcp_2025_11_25_test.dart,test/mcp_2026_07_28_test.dart, streamable HTTP/client/server tests, JSON Schema testsValidation
dart format --output=none --set-exit-if-changed .git diff --checkdart analyzedart testdart run test/conformance/run_2025_server_conformance.dart --timeout-seconds 90 --output-dir .dart_tool/conformance/ci_2025_server(49 passed, 0 failed)npx -y @modelcontextprotocol/conformance@0.2.0-alpha.1 client --command "dart run test/conformance/mcp_2026_rc_client.dart" --suite all --spec-version 2025-11-25 --verbose -o .dart_tool/conformance/ci_2025_client(242 passed, 0 failed)dart run test/conformance/run_2026_rc_server_conformance.dart --timeout-seconds 90 --output-dir .dart_tool/conformance/ci_2026_server(19 passed, 0 failed/timeout)dart run test/conformance/run_2026_rc_client_conformance.dart --timeout-seconds 90 --output-dir .dart_tool/conformance/ci_2026_client(35 passed, 0 failed/timeout)Stacked on #270. This is a draft RC PR and should stay off
mainuntil the official spec release.