Skip to content

Validate implementation wire fields#258

Closed
leehack wants to merge 1 commit into
spec/icon-uri-validationfrom
spec/implementation-wire-validation
Closed

Validate implementation wire fields#258
leehack wants to merge 1 commit into
spec/icon-uri-validationfrom
spec/implementation-wire-validation

Conversation

@leehack

@leehack leehack commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • validate required and optional Implementation string fields with FormatException
  • reject malformed icons lists and present-null optional fields in wire JSON
  • require websiteUrl to be an absolute URI on parse and serialization

Validation

  • dart format lib/src/types/initialization.dart test/types_test.dart
  • dart analyze
  • dart test test/types_test.dart --name Implementation
  • dart test test/types_test.dart
  • dart test test/mcp_2025_11_25_test.dart
  • dart test test/mcp_2026_07_28_test.dart
  • git diff --check
  • dart test

@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.59%. Comparing base (eff3be4) to head (846a480).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           spec/icon-uri-validation     #258      +/-   ##
============================================================
+ Coverage                     88.57%   88.59%   +0.02%     
============================================================
  Files                            47       47              
  Lines                          9432     9456      +24     
============================================================
+ Hits                           8354     8378      +24     
  Misses                         1078     1078              
Flag Coverage Δ
unittests 88.59% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leehack

leehack commented Jun 1, 2026

Copy link
Copy Markdown
Owner Author

Closing this draft micro PR because the RC spec work has been consolidated into a smaller reviewable stack. This change is preserved in #271 (type/schema validation); the consolidated tip is tree-identical to the previous micro-stack tip.

@leehack leehack closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant