Skip to content

Restrict elicitation content numbers to integers#260

Closed
leehack wants to merge 1 commit into
spec/integer-wire-field-validationfrom
spec/elicitation-content-integer-values
Closed

Restrict elicitation content numbers to integers#260
leehack wants to merge 1 commit into
spec/integer-wire-field-validationfrom
spec/elicitation-content-integer-values

Conversation

@leehack

@leehack leehack commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • align ElicitResult.content numeric values with the current stable and draft schemas by allowing only integers
  • normalize whole-number JSON numeric values to ints while rejecting fractional values
  • update stable/draft regression coverage and the changelog note

Validation

  • dart test test/elicitation_test.dart
  • dart test test/mcp_2025_11_25_test.dart test/mcp_2026_07_28_test.dart
  • dart analyze
  • git diff --check
  • dart test

@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.62%. Comparing base (83814a7) to head (13d9fc9).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           spec/integer-wire-field-validation     #260   +/-   ##
===================================================================
  Coverage                               88.61%   88.62%           
===================================================================
  Files                                      47       47           
  Lines                                    9472     9480    +8     
===================================================================
+ Hits                                     8394     8402    +8     
  Misses                                   1078     1078           
Flag Coverage Δ
unittests 88.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leehack

leehack commented Jun 1, 2026

Copy link
Copy Markdown
Owner Author

Closing this draft micro PR because the RC spec work has been consolidated into a smaller reviewable stack. This change is preserved in #271 (type/schema validation); the consolidated tip is tree-identical to the previous micro-stack tip.

@leehack leehack closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant