Skip to content

Align MRTR sampling input request shape#251

Closed
leehack wants to merge 1 commit into
spec/integer-schema-number-boundsfrom
spec/mrtr-sampling-request-shape
Closed

Align MRTR sampling input request shape#251
leehack wants to merge 1 commit into
spec/integer-schema-number-boundsfrom
spec/mrtr-sampling-request-shape

Conversation

@leehack

@leehack leehack commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • omit legacy task metadata from embedded MRTR sampling/createMessage input requests
  • reject incoming embedded sampling/createMessage params that still carry legacy task metadata
  • add 2026 RC regression coverage for serialization and malformed MRTR parsing

Spec context

Part of #177.

Tests

  • dart format lib/src/types/json_rpc.dart test/mcp_2026_07_28_test.dart
  • dart test test/mcp_2026_07_28_test.dart
  • git diff --check
  • dart analyze
  • dart test

@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.48%. Comparing base (15a5d14) to head (9bcb972).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           spec/integer-schema-number-bounds     #251   +/-   ##
==================================================================
  Coverage                              88.48%   88.48%           
==================================================================
  Files                                     47       47           
  Lines                                   9353     9354    +1     
==================================================================
+ Hits                                    8276     8277    +1     
  Misses                                  1077     1077           
Flag Coverage Δ
unittests 88.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leehack

leehack commented Jun 1, 2026

Copy link
Copy Markdown
Owner Author

Closing this draft micro PR because the RC spec work has been consolidated into a smaller reviewable stack. This change is preserved in #271 (type/schema validation); the consolidated tip is tree-identical to the previous micro-stack tip.

@leehack leehack closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant