Skip to content

Notify user if txm fails saving transactions#297

Merged
GabrielMartinezRodriguez merged 1 commit into
masterfrom
gabriel/hook-flush-fails
Jan 7, 2025
Merged

Notify user if txm fails saving transactions#297
GabrielMartinezRodriguez merged 1 commit into
masterfrom
gabriel/hook-flush-fails

Conversation

@GabrielMartinezRodriguez

@GabrielMartinezRodriguez GabrielMartinezRodriguez commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Linked issues

closes https://linear.app/happychain/issue/HAPPY-249/notify-user-if-txm-fails-saving-a-transaction

Description

Added support for transaction save failure notifications through a new hook type. When transactions fail to save, the system now emits a TransactionSaveFailed hook instead of throwing an error. This enables better error handling and allows consumers to react to save failures through hooks.

Key changes:

  • Implemented new hook type for transaction save failures
  • Modified TransactionCollector to emit events instead of throwing errors
Toggle Checklist

Checklist

Basics

  • B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
  • B2. This PR is not so big that it should be split & addresses only one concern.
  • B3. The PR targets the lowest branch it can (ideally master).

Correctness

  • C1. Builds and passes tests.

  • C2. The code is properly parameterized & compatible with different environments.

  • C3. I have manually tested my changes & connected features.

  • C4. I have performed a thorough self-review of my code after submitting the PR.

Architecture & Documentation

  • D1. I made it easy to reason locally about the code.
  • D2. All public-facing APIs & meaningful internal APIs are properly documented.
  • D3. If appropriate, the general architecture is documented.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Dec 6, 2024

Copy link
Copy Markdown

Deploying happychain with  Cloudflare Pages  Cloudflare Pages

Latest commit: b2123e8
Status: ✅  Deploy successful!
Preview URL: https://dcf4a65e.happychain.pages.dev
Branch Preview URL: https://gabriel-hook-flush-fails.happychain.pages.dev

View logs

GabrielMartinezRodriguez commented Dec 6, 2024

Copy link
Copy Markdown
Contributor Author

@linear

linear Bot commented Dec 6, 2024

Copy link
Copy Markdown

@norswap norswap added merge-blocked Ready to merge, waiting for downstack and removed reviewing-1 Ready for, or undergoing first-line review labels Dec 20, 2024
@GabrielMartinezRodriguez GabrielMartinezRodriguez mentioned this pull request Dec 20, 2024
10 tasks
Base automatically changed from gabriel/flush-mechanism to master January 7, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-blocked Ready to merge, waiting for downstack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants