Notify user if txm fails saving transactions#297
Merged
Conversation
Deploying happychain with
|
| Latest commit: |
b2123e8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dcf4a65e.happychain.pages.dev |
| Branch Preview URL: | https://gabriel-hook-flush-fails.happychain.pages.dev |
This was referenced Dec 6, 2024
Merged
Merged
Merged
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 6, 2024
Merged
10 tasks
This was referenced Dec 9, 2024
Merged
Merged
norswap
approved these changes
Dec 20, 2024
28048b1 to
b3b5c1d
Compare
Merged
10 tasks
b3b5c1d to
83842ef
Compare
This was referenced Dec 26, 2024
9223e7a to
4380b80
Compare
83842ef to
2765c4e
Compare
2765c4e to
e1e535a
Compare
4380b80 to
28e799d
Compare
e1e535a to
6d6cd5c
Compare
28e799d to
b2123e8
Compare
This was referenced Jan 22, 2025
This was referenced Feb 3, 2025
Merged
This was referenced Feb 11, 2025
Closed
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Linked issues
closes https://linear.app/happychain/issue/HAPPY-249/notify-user-if-txm-fails-saving-a-transaction
Description
Added support for transaction save failure notifications through a new hook type. When transactions fail to save, the system now emits a
TransactionSaveFailedhook instead of throwing an error. This enables better error handling and allows consumers to react to save failures through hooks.Key changes:
TransactionCollectorto emit events instead of throwing errorsToggle Checklist
Checklist
Basics
norswap/build-system-caching).Correctness
C1. Builds and passes tests.
C2. The code is properly parameterized & compatible with different environments.
C3. I have manually tested my changes & connected features.
C4. I have performed a thorough self-review of my code after submitting the PR.
Architecture & Documentation