Txm hooks#229
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
10 tasks
67edffc to
b5ecde9
Compare
10 tasks
HAPPY-112 txmanager: We should implement a system to notify users of the status of their transactions
This system should notify users when certain events occur, for instance:
In addition, it might be a good idea to allow users to proactively check the status of their transactions |
36d0751 to
8fdcc44
Compare
c5452a4 to
e3016df
Compare
Merged
10 tasks
Merged
10 tasks
norswap
reviewed
Nov 28, 2024
8fdcc44 to
7df84a7
Compare
a85c76a to
78b4083
Compare
10 tasks
norswap
approved these changes
Dec 4, 2024
| export type TxmHookHandler = (event: TxmHookPayload) => void | ||
|
|
||
| export class HookManager { | ||
| private hooks: Record<TxmHookType | "All", TxmHookHandler[]> |
Collaborator
There was a problem hiding this comment.
Should we just add "All" to TxmHookType? Seems like it would work nicely. We can also mandate type in addHook to be explicit then.
1d5b007 to
a520cec
Compare
This was referenced Dec 6, 2024
Merged
This was referenced Dec 13, 2024
Merged
Merged
This was referenced Dec 26, 2024
This was referenced Jan 22, 2025
This was referenced Feb 3, 2025
Merged
This was referenced Feb 11, 2025
Closed
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Linked Issues
Description
Implemented a mechanism that allows originators to be notified when certain events occur. Currently, only the
TransactionStatusChangedevent is specified, which is triggered when a transaction's status changes. Additionally, this PR modifies the randomness service to reveal the commitment value only if the commitment transaction has succeededToggle Checklist
Checklist
Basics
norswap/build-system-caching).Reminder: PR review guidelines
Correctness
testnet, mainnet, standalone wallet, ...).
This PR has been tested using the randomness service on localhost, interacting with the Anvil blockchain
and have updated the code & comments accordingly.
Architecture & Documentation
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
comments.
in a Markdown document.