Allow run multiple txm simultaneously within the same service#285
Merged
Conversation
Deploying happychain with
|
| Latest commit: |
4f82a92
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4108753e.happychain.pages.dev |
| Branch Preview URL: | https://gabriel-txm-address.happychain.pages.dev |
This was referenced Dec 4, 2024
Merged
Merged
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
10 tasks
not-reed
approved these changes
Dec 4, 2024
7199d82 to
a4d48c9
Compare
c78883b to
dc6a69e
Compare
Merged
10 tasks
norswap
approved these changes
Dec 5, 2024
a4d48c9 to
a892764
Compare
dc6a69e to
f1f9772
Compare
a892764 to
41328be
Compare
f1f9772 to
7b632c4
Compare
41328be to
93163a6
Compare
aa4677b to
b331ee9
Compare
6e190bb to
bdebce4
Compare
Merged
10 tasks
b331ee9 to
caaf521
Compare
bdebce4 to
b474fe4
Compare
This was referenced Dec 26, 2024
caaf521 to
5b00c8c
Compare
b474fe4 to
473b965
Compare
500c1de to
8869e42
Compare
473b965 to
4f82a92
Compare
This was referenced Jan 22, 2025
This was referenced Feb 3, 2025
Merged
This was referenced Feb 11, 2025
Closed
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Linked issues
closes https://linear.app/happychain/issue/HAPPY-230/txmanager-do-not-use-id-in-the-transaction-use-the-account-instead-for
Description
TransactionManagernow only processesTransactionsthat have the samefromfield as theTransactionManager, allowing multipleTransactionManagerto operate simultaneously within the same service.createTransactionmethod inTransactionManagerto handle transaction creation. This eliminates the need to pass thefromaddress andchainIdto the Transaction every time a new one is created. This was redundant because theTransactionManageralready holds that information.idfield from theTransactionManageras it was unused. It was initially intended to serve as a discriminator for supporting multipleTransactionManagerin the same service, but this functionality is now achieved using thefromfield.fromaddress field to Transaction objects to track the sender.fromcolumn.createTransactioninstead ofcontructorToggle Checklist
Checklist
Basics
norswap/build-system-caching).Correctness
Architecture & Documentation