Add flush mechanism#289
Merged
Merged
Conversation
Deploying happychain with
|
| Latest commit: |
6d6cd5c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b1523595.happychain.pages.dev |
| Branch Preview URL: | https://gabriel-flush-mechanism.happychain.pages.dev |
Merged
10 tasks
This was referenced Dec 5, 2024
Merged
Merged
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
10 tasks
dc6a69e to
f1f9772
Compare
2e198fe to
4cb7169
Compare
f1f9772 to
7b632c4
Compare
4cb7169 to
4b2be53
Compare
7b632c4 to
eee782f
Compare
4b2be53 to
e2320c0
Compare
eee782f to
6e190bb
Compare
e2320c0 to
28048b1
Compare
This was referenced Dec 6, 2024
Merged
Merged
10 tasks
norswap
reviewed
Dec 20, 2024
| pendingFlush, | ||
| notPersisted, | ||
| metadata, | ||
| }: TransactionConstructorConfig & { |
Collaborator
There was a problem hiding this comment.
I think we should reorder the fields above, such that the fields from TransactionConstructorConfig come first, followed by the rest.
I'm not quite clear on why the distinction exists at all btw, what's the thinking there?
Merged
10 tasks
bdebce4 to
b474fe4
Compare
b3b5c1d to
83842ef
Compare
This was referenced Dec 26, 2024
b474fe4 to
473b965
Compare
83842ef to
2765c4e
Compare
473b965 to
4f82a92
Compare
2765c4e to
e1e535a
Compare
e1e535a to
6d6cd5c
Compare
This was referenced Jan 22, 2025
This was referenced Feb 3, 2025
Merged
This was referenced Feb 11, 2025
Closed
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Linked issues
closes https://linear.app/happychain/issue/HAPPY-250/only-flush-transactions-that-have-been-modified
Description
This PR aims to add a mechanism to avoid re-updating transactions that have no changes
Key changes:
pendingFlushandnotPersistedfield to track database persistenceupdateTransaction,updateTransactions, andsaveTransactionsinto a singlesaveTransactionsmethodToggle Checklist
Checklist
Basics
norswap/build-system-caching).Correctness
Architecture & Documentation