Skip to content

test: add test for format.sas trailing period stripping in XPT roundtrip#802

Closed
LeonidasZhak wants to merge 1 commit into
tidyverse:mainfrom
LeonidasZhak:test/xpt-format-trailing-period
Closed

test: add test for format.sas trailing period stripping in XPT roundtrip#802
LeonidasZhak wants to merge 1 commit into
tidyverse:mainfrom
LeonidasZhak:test/xpt-format-trailing-period

Conversation

@LeonidasZhak

Copy link
Copy Markdown

Adds a test that explicitly verifies the trailing period stripping behavior documented in PR #801.

The SAS transport format does not store trailing periods in format names (e.g., "DATE9." becomes "DATE9"). This test confirms that write_xpt() to read_xpt() correctly strips trailing periods from format.sas attributes.

This test complements the existing "can roundtrip format attribute" test, which only uses formats without trailing periods.

Checks run locally:

  • devtools::test(filter = "haven-sas") - all 73 tests pass
  • Full test suite: 1 pre-existing snapshot failure in test-labelled-pillar.R (Unicode encoding), unrelated to this change

@LeonidasZhak

Copy link
Copy Markdown
Author

Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant