test: add tests for read_sas format.sas and display_width XPT non-retention#804
Closed
LeonidasZhak wants to merge 1 commit into
Closed
test: add tests for read_sas format.sas and display_width XPT non-retention#804LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
…PT non-retention - Test that read_sas() correctly reads format.sas attributes from sas7bdat files - Test that display_width is NOT retained during XPT round-trips (documenting limitation) Complements PR tidyverse#801 (metadata docs) and tidyverse#802 (trailing period test).
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small tests that document metadata behavior:
read_sas format.sas attribute: Verifies that
read_sas()correctly reads theformat.sasattribute from sas7bdat files (e.g.$GENDERfor gender,WORKSHOPfor workshop). This complements the documentation in PR docs: document retained metadata for read_xpt/write_xpt (#719) #801.display_width not retained by XPT: Documents that the
display_widthattribute (used by SPSS) is NOT retained duringwrite_xpt()→read_xpt()round-trips. This clarifies a limitation that differs from SPSS behavior (wheredisplay_widthdoes round-trip).Relation to existing PRs:
Checks run locally:
devtools::test(filter = "haven-sas")— all 76 tests pass (73 original + 3 new)