test: add test for write_xpt invisibly returning original data unaltered#819
Closed
LeonidasZhak wants to merge 1 commit into
Closed
test: add test for write_xpt invisibly returning original data unaltered#819LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
Adds a test verifying that write_xpt() returns the original data frame invisibly and unaltered, matching the pattern used by write_dta() and write_sav() in their respective test files. This brings write_xpt test coverage in line with the other write functions.
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a test verifying that
write_xpt()returns the original data frame invisibly and unaltered, matching the pattern used bywrite_dta()andwrite_sav()in their respective test files.Changes
tests/testthat/test-haven-sas.R: Added "invisibly returns original data unaltered" test forwrite_xpt()Motivation
Both
test-haven-stata.Randtest-haven-spss.Rhave tests verifying that their respective write functions (write_dta()andwrite_sav()) return the input data invisibly and unaltered. This test was missing forwrite_xpt()intest-haven-sas.R.The test verifies an important behavior: that
write_xpt()doesn't modify the input data frame (e.g., doesn't strip attributes or change values) and returns it invisibly.Testing
The single failure is a pre-existing issue with the
cols_onlydeprecation test (line 132) unrelated to this change.Relation to existing PRs