Feat/control display via cms settings - #9
Open
sig-lani wants to merge 27 commits into
Open
Conversation
- add boolean to indicate if display should be disabled - add tab with checkbox in settings panel to provide override value
- add condition to check for site config override and return original html without insertion of EnvBar if true
…ate variable. - allow developer to configure to fit themes where the auto insert would be inappropriate
- add usage instructions for CMS override setting - add developer instructions for yml configuration and template variable usage
Fix link to Override Setting screenshot
Modifies the documentation to use SilverStripe namespacing in params and returns. Also minor changes to formatting of doc blocks for stylistics preference.
Add Scrutinizer Code Quality badge. Remove codecov badge.
sig-lani
marked this pull request as ready for review
June 23, 2020 03:57
Collaborator
Author
|
@smgrc have made another commit to ensure build tasks pass... need some unit tests for added functionality though. |
Modify tests to better reflect current status of PHP and SilverStripe. Also loosen script to check tests directory (to allow for more unit tests to run in future).
This was
linked to
issues
Jun 24, 2020
The travis tests are failing to build due to unresolvable requirements - it seems likely this is a result of using unstable versions of SilverStripe.
The tests using PHP 5.6 and PHP 7.0 do not build because the version of SilverStripe being built does not support PHP<7.1 Also add PHP 7.4.
silverstripe/postgresql 2.1.x-dev was not resolving to an installable package. Prefer using a stable tagged version. Also remove --no-suggest while we're at it, as this is deprecated in composer 2.
chore: Fix travis config.
…b.com/signify-nz/silverstripe-environmentindicator into feat/control-display-via-cms-settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch should resolve issues raised in #4 #6 #7 #8