Alternative embedding methods

[sig-steve]

Embedding the EnvBar as the first element in the body tag doesn't always work well for all sites.

What do you think of providing the EnvBar via a template variable, e.g. $EnvBar and providing a config option to disable the automatic embedding.

[lanifield]

Are you talking about a config option in the CMS settings (in which case this issue can be related to #4 ) or are you suggesting an environment variable in the .env, or a yaml config?

[sig-steve]

The idea is to be able to embed the environment bar so that for cases where embedding it as the first child of the body isn't appropriate, such as when there is a fixed position menu bar that would overlay it.

As such, I think there would need to be an option to turn off the default behaviour. Unlike #4, this would need to be a theme-specific setting, so I think it should be in the YAML config, rather than in the admin interface.

An addtional wrinkle is that a site might have multiple themes, where one theme may need one kind of embedding, and another might require the other.

[sig-lani]

@sig-steve can you please review and test to ensure the modifications on the https://github.com/signify-nz/silverstripe-environmentindicator/tree/feat/control-display-via-cms-settings branch meets your expectations?

I will be writing unit tests (when I get a moment to do so) to ensure future builds keep this functionality and to confirm the solution satisfies the requirements.