Skip to content

chore(build): resolve SolidWorks interop assemblies via an overridable property#196

Open
ycpss91255 wants to merge 1 commit into
ros:masterfrom
ycpss91255-research:pr-build-swdir
Open

chore(build): resolve SolidWorks interop assemblies via an overridable property#196
ycpss91255 wants to merge 1 commit into
ros:masterfrom
ycpss91255-research:pr-build-swdir

Conversation

@ycpss91255

Copy link
Copy Markdown
Contributor

Problem

The SolidWorks interop references used a fixed ..\..\..\..\..\ relative
HintPath that only resolves when the repo sits at a specific depth under the
SolidWorks install, so a normal clone fails to find the assemblies.

Fix

Resolve the interop assemblies through an overridable SolidWorksDir MSBuild
property (default: the standard install path). Override with
-p:SolidWorksDir=... or a SolidWorksDir environment variable if SolidWorks
is installed elsewhere.

Notes

Split out from #191 per the review there; the .NET 4.8 retarget is the other
half.

…e property

The interop HintPaths used a fixed ..\..\..\..\..\ relative path that only
resolves when the repo sits at a specific depth under the SolidWorks install,
so a normal clone does not build. Resolve them through a SolidWorksDir property
(default: the standard install path); override with /p:SolidWorksDir=... or a
SolidWorksDir environment variable if installed elsewhere.

@brawner brawner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the helpful contribution! Will merge once I can test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants