chore(build): retarget the add-in to .NET Framework 4.8#191
Open
ycpss91255 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Can this PR be split into two. It's two separate bug fixes |
The 4.5.2 targeting pack is no longer installed by current Visual Studio, so the build fails with MSB3644. 4.8 is in-place compatible with the existing net45 / net452 dependencies. Also add v4.8 to the post-build RegAsm framework check.
ycpss91255
changed the title
Contributor
Author
|
Split this into two per your suggestion:
They touch different lines and apply independently. |
brawner
approved these changes
Jun 3, 2026
brawner
left a comment
brawner
left a comment
Collaborator
There was a problem hiding this comment.
Looks great. Thanks. Will merge when I get the chance to test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The add-in targets .NET Framework 4.5.2, whose targeting pack is no longer
installed by current Visual Studio, so the build fails with MSB3644.
Fix
Retarget the add-in to .NET Framework 4.8 (in-place compatible with the
existing net45 / net452 dependencies) and add v4.8 to the post-build RegAsm
framework check.
Notes
Split into two per your suggestion. The SolidWorks interop path change is the
companion PR #196.