Various fixes + ggplot2 4.0.0 compatibility#53
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs a systematic refactoring to standardize parameter naming across the halfmoon package's testing suite. The main changes include:
- Renaming
.groupparameter to.exposurein ESS-related functions - Renaming
treatment_levelparameter to.focal_levelacross calibration and ROC functions - Updating comment references to reflect the new parameter names
- Removing a test assertion for coordinate system type in ROC plots
- Adding pipeline operators and
na.omit()call for y-axis label processing - Adding new test coverage for
facet_scalesparameter functionality - Updating SVG snapshot files to reflect changes in plot rendering (axis scales and positioning)
Reviewed Changes
Copilot reviewed 42 out of 82 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test-plot_roc.R | Removed coordinate system test assertion |
| test-plot_qq.R | Updated comment from treatment_level to .focal_level |
| test-plot_mirror_distributions.R | Added pipeline operators for y-label processing; added new facet_scales tests |
| test-plot_ess.R | Changed .group to .exposure in function calls |
| test-plot_calibration.R | Updated parameter name and comments from treatment_level to .focal_level |
| test-geom_calibration.R | Updated aesthetic mappings and comments to use new parameter names |
| test-check_model_auc.R | Updated parameter name and comments from treatment_level to .focal_level |
| test-check_ess.R | Changed .group parameter to .exposure throughout |
| test-check_balance_interactions.R | New test file for interaction validation |
| test-bal_qq.R | Updated comments to reference .focal_level |
| Multiple SVG files | Updated snapshots reflecting plot rendering changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@malcolmbarrett I've opened a new pull request, #54, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
|
@malcolmbarrett I've opened a new pull request, #55, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: malcolmbarrett <23123711+malcolmbarrett@users.noreply.github.com>
Co-authored-by: malcolmbarrett <23123711+malcolmbarrett@users.noreply.github.com>
Remove redundant numeric conversion in plot_mirror_distributions test
Use explicit namespace for stats::na.omit() in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR addresses various issues found while working with recently developed tools while polishing the balance chapter. It relatedly addresses ggplot2 4.0.0 compatibility
Closes #52