Skip to content

Use explicit namespace for stats::na.omit() in tests#55

Merged
malcolmbarrett merged 3 commits into
bugsfrom
copilot/sub-pr-53-again
Nov 4, 2025
Merged

Use explicit namespace for stats::na.omit() in tests#55
malcolmbarrett merged 3 commits into
bugsfrom
copilot/sub-pr-53-again

Conversation

Copilot AI commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Addresses review feedback to use explicit namespace qualification for stats::na.omit() in test file for consistency with the rest of the codebase.

Changes

  • Updated na.omit() to stats::na.omit() in tests/testthat/test-plot_mirror_distributions.R

This aligns with existing usage in R/utils-group.R and R/check_balance.R, improving code clarity and avoiding potential namespace conflicts.

# Before
y_labels <- built$layout$panel_params[[1]]$y$get_labels() |>
  na.omit() |>
  as.numeric()

# After
y_labels <- built$layout$panel_params[[1]]$y$get_labels() |>
  stats::na.omit() |>
  as.numeric()

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: malcolmbarrett <23123711+malcolmbarrett@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on ggplot2 4.0.0 compatibility fixes Use explicit namespace for stats::na.omit() in tests Nov 4, 2025
Copilot AI requested a review from malcolmbarrett November 4, 2025 15:47
@malcolmbarrett
malcolmbarrett marked this pull request as ready for review November 4, 2025 16:01
@malcolmbarrett
malcolmbarrett merged commit a46ab9d into bugs Nov 4, 2025
@malcolmbarrett
malcolmbarrett deleted the copilot/sub-pr-53-again branch November 4, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants