Skip to content

Remove redundant numeric conversion in plot_mirror_distributions test#54

Merged
malcolmbarrett merged 2 commits into
bugsfrom
copilot/sub-pr-53
Nov 4, 2025
Merged

Remove redundant numeric conversion in plot_mirror_distributions test#54
malcolmbarrett merged 2 commits into
bugsfrom
copilot/sub-pr-53

Conversation

Copilot AI commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Addresses feedback on #53 regarding duplicate type conversion in test assertions.

Changes

  • Removed redundant as.numeric() call in tests/testthat/test-plot_mirror_distributions.R:230 where y_labels is already converted to numeric in the pipeline

Before:

y_labels <- built$layout$panel_params[[1]]$y$get_labels() |>
  na.omit() |>
  as.numeric()
expect_true(all(as.numeric(y_labels) >= 0))

After:

y_labels <- built$layout$panel_params[[1]]$y$get_labels() |>
  na.omit() |>
  as.numeric()
expect_true(all(y_labels >= 0))

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: malcolmbarrett <23123711+malcolmbarrett@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on ggplot2 4.0.0 compatibility Remove redundant numeric conversion in plot_mirror_distributions test Nov 4, 2025
Copilot AI requested a review from malcolmbarrett November 4, 2025 15:47
@malcolmbarrett
malcolmbarrett marked this pull request as ready for review November 4, 2025 16:01
@malcolmbarrett
malcolmbarrett merged commit fa894ea into bugs Nov 4, 2025
4 checks passed
@malcolmbarrett
malcolmbarrett deleted the copilot/sub-pr-53 branch November 4, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants