Skip to content

Drop support for EOL Python 3.9 - #1354

Open
hugovk wants to merge 7 commits into
pypa:mainfrom
hugovk:rm-eol
Open

Drop support for EOL Python 3.9#1354
hugovk wants to merge 7 commits into
pypa:mainfrom
hugovk:rm-eol

Conversation

@hugovk

@hugovk hugovk commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Take two of #1263, and allow testing feature branches to prevent accidental closures and other problems of developing on main.

@henryiii

Copy link
Copy Markdown
Contributor

Won't this double-run CI when we make a PR from a in-repo branch? (Also, separating that out would be better).

@hugovk

hugovk commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Won't this double-run CI when we make a PR from a in-repo branch?

Yes, but I recommend creating PRs from your own fork and not from upstream:

  • You get total control on whether the CI is even enabled
  • By default it's disabled, you need explicit opt-in
  • You don't "clutter" upstream with personal branches, which may live for years and affect everyone who forks

It's not common. Of the last 300 PRs to this repo, only 16 were in-repo:

  • 11 dependabot
  • 4 Henry
  • 1 Brett

And the CI is fast, it doesn't use up too much time.

Plus, they're technically not really double-runs, a push and a pull_request test different things. A push is just what's on the branch. A pull_request simulates a merge against main, and tests that. Occasionally you get different results, and this can be useful info!

(Also, separating that out would be better).

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants