Drop support for EOL Python 3.9 - #1263
Conversation
|
I'd like to wait on this a bit, I don't want to drop two Python versions in one release (we just dropped 3.8). |
|
However, this was a perfect example to compare my drop Python skill against a traditional manual drop. I triggered this and then did a diff comparison with Claude: 🤖 AI text below 🤖 Both diffs are the same "Drop EOL Python 3.9" change, and the shared core is byte-for-byte identical. The differences are at the edges: What's identicalBoth make exactly the same edits to: Where they differ1.
(Both drop 3.9; they disagree on the replacement. PR picks the newest, current picks the new floor.) 2. PR #1263 also simplifies
3.
4. 5. NetPR #1263 is the more complete version: it also does the |
brettcannon
left a comment
There was a problem hiding this comment.
There's some merge conflicts to fix.
|
Conflicts resolved! |
|
Thanks! But I would still like to save this till after a release, we should probably try to push for a release soon. |
|
Hopefully, we'll release very soon, then this will be ready to merge a couple of days after that. |
|
Sorry, didn't mean to close this! I'd made the PR on packaging/.github/workflows/test.yml Lines 5 to 7 in 45a8b34 And I want to make sure CI passes before opening a PR and pinging all the maintainers. Then I forgot, and reset my |
|
Take two: #1354. |
|
You can also make a PR to your fork to get CI. |
|
Indeed, but that's also adding extra friction to contribution. |
pip 26.1 already dropped support: pypa/pip#13905.