Skip to content

Take into account the value of request parameter page for caching the…#444

Merged
erral merged 3 commits into
masterfrom
erral-sitemap-cache
Jun 4, 2026
Merged

Take into account the value of request parameter page for caching the…#444
erral merged 3 commits into
masterfrom
erral-sitemap-cache

Conversation

@erral

@erral erral commented Jun 2, 2026

Copy link
Copy Markdown
Member

… generated sitemap

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

In #382 I introduced the sitemap-index.xml here, to be aligned with latest changes in sitemap generation where search engines ignored sitemap files with lot of URLs.

The method that generates the sitemap is cached but it does not take the page parameter into account, so no matter which is the page you requested you are returned the first cached page.

This PR introduces the page parameter's value in the caching key .

@mister-roboto

Copy link
Copy Markdown

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral

erral commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

Comment thread news/+sitemapcache.bugfix
@erral

erral commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@erral erral mentioned this pull request Jun 3, 2026
8 tasks

@thet thet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This targets Plone 6.3.
Ref: #446

@erral

erral commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@erral erral merged commit 96ee048 into master Jun 4, 2026
12 checks passed
@erral erral deleted the erral-sitemap-cache branch June 4, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants