Skip to content

Take into account the value of request parameter page for caching the… #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erral merged 3 commits into from
Jun 4, 2026
Merged

Take into account the value of request parameter page for caching the… #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7ea521
Take into account the value of request parameter page for caching the…
erral Jun 2, 2026
9af43c1
rename changelog
erral Jun 2, 2026
76b1125
Merge branch 'master' into erral-sitemap-cache
erral Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/+sitemapcache.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Take into account the value of request parameter page for caching the generated sitemap @erral
Comment thread
erral marked this conversation as resolved.
3 changes: 2 additions & 1 deletion src/plone/app/layout/sitemap/sitemap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ def _render_cachekey(fun, self):
url = self.context.absolute_url()
catalog = getToolByName(self.context, "portal_catalog")
counter = catalog.getCounter()
return f"{url}/{self.filename}/{counter}"
page = self.request.get("page", 0)
return f"{url}/{self.filename}/{counter}/{page}"


class SiteMapView(BrowserView):
Expand Down