Skip to content

Take into account the value of request parameter page for caching the…#445

Closed
erral wants to merge 16 commits into
6.xfrom
6.x-erral-sitemap-cache
Closed

Take into account the value of request parameter page for caching the…#445
erral wants to merge 16 commits into
6.xfrom
6.x-erral-sitemap-cache

Conversation

@erral

@erral erral commented Jun 2, 2026

Copy link
Copy Markdown
Member

… generated sitemap

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

Like #444 for the 6.x branch (Plone 6.2)

@mister-roboto

Copy link
Copy Markdown

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral

erral commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@erral erral changed the base branch from master to 6.x June 2, 2026 13:06
@erral erral closed this Jun 3, 2026
@erral erral deleted the 6.x-erral-sitemap-cache branch June 18, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants