Add reqsig envelope package and driver sign/verify methods#34
Merged
Conversation
- reqsig: canonical pilot-req-v1 request envelopes (domain-separated, fixed-charset fields, +/-300s freshness, strict canonical parsing) and pilot-verdict-v1 registry verdicts with a build-embedded kid keyring (fail-closed, ldflags-overridable) - driver: SignEnvelope / VerifyEnvelope / VerifyEnvelopeMaxSkew mirroring daemon IPC commands 0x33-0x36
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Jul 3, 2026
Merged
- SignEnvelope validates body hash length (64 hex) and audience (1-64) client-side; VerifyEnvelope bounds envelope (512) and signature (128) so request-frame allocation is independent of caller input - error-path tests for reqsig envelope/verdict validation branches
Read already rejected oversized frames; Write now refuses them before allocation instead of writing bytes the peer would drop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reqsigpackage: canonicalpilot-req-v1request-signature envelopes (domain-separated, fixed-charset fields, ±300s freshness, strict canonical parsing) proving a request originates from a registered Pilot nodepilot-verdict-v1registry verdicts with a build-embedded kid keyring (fail-closed, ldflags-overridable) for offline verificationSignEnvelope/VerifyEnvelope/VerifyEnvelopeMaxSkewmirroring daemon IPC commands 0x33–0x36First of four PRs for the external signature-verification capability (registry HTTPS endpoint, daemon IPC, app-store origin/appkit follow). Spec lands in pilotprotocol
docs/SIGNATURE-VERIFICATION.md.Testing
go test ./reqsig/ ./driver/— envelope/verdict round-trips, tamper/parse rejection tables, keyring fail-closed, driver wire-shape tests🤖 Generated with Claude Code