Add envelope sign/verify IPC commands and pilotctl front-ends#350
Merged
Conversation
- CmdSignEnvelope (0x33): the daemon constructs and signs pilot-req-v1 envelopes itself; no code path signs caller-supplied bytes (the IPC socket admits any same-UID process, so this is the security boundary) - CmdVerifyEnvelope (0x35): local-first key resolution via the key-exchange peer cache, registry fallback, optional standing check - pilotctl sign-request / verify-request - docs/SIGNATURE-VERIFICATION.md: full three-surface spec
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- bound --max-skew to 0-86400 before the uint32 conversion - annotate the operator-supplied --body-file read (G304) - ignore best-effort cleanup errors explicitly in IPCServer.Start - regenerate docs/cli-reference.md for sign-request/verify-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CmdSignEnvelope(0x33): the daemon constructs and signspilot-req-v1envelopes itself — no code path signs caller-supplied bytes. The IPC socket admits any same-UID process, so this restriction is the security boundary.CmdVerifyEnvelope(0x35): local-first key resolution via the key-exchange peer cache (registry fallback on miss), optional standing check (online/last_seen_unix/key_generation/network_member, tolerant of older registries)pilotctl sign-request/verify-requestdocs/SIGNATURE-VERIFICATION.md: the full three-surface spec (registry HTTPS oracle, daemon IPC, offline verdicts)Depends on pilot-protocol/common#34 (
reqsig+ driver methods). Pin bump follows on this branch.Testing
10 handler tests / 23 subtests (sign→verify round trip, refusal tables, cache-vs-registry paths, standing tolerance) + 6 pilotctl subprocess tests asserting the raw body never reaches the daemon.
🤖 Generated with Claude Code