Add daemon-attested origin and appkit per-node rate limiting#26
Merged
Conversation
- ipc.Envelope gains an Origin block set only via CallWithOrigin; the broker strips caller-supplied origins on cross-app calls so apps cannot forge sender identity through the broker - pkg/appkit: RequireOrigin, LimitPerNode, RequireEnvelope, and a sliding-window PerNodeLimiter keyed on verified node identity - new identity.verify manifest capability (declarative, like the rest of the grant model)
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ipc.Envelopegains anOriginblock (node, node_id, authenticated, trusted) set only via the new trustedService.CallWithOriginpath; the broker strips caller-supplied origins on cross-app calls so apps cannot forge sender identity through the brokerpkg/appkit:RequireOrigin,LimitPerNode,RequireEnvelope(verification via injectedVerifyFunc— wire it todriver.VerifyEnvelope), and a sliding-windowPerNodeLimiterkeyed on verified node identityidentity.verifymanifest capability (declarative, consent-time, like the rest of the grant model)No new module dependencies. Companion to pilot-protocol/common#34, pilot-protocol/rendezvous#(verify endpoint), pilot-protocol/pilotprotocol#(envelope IPC). Spec: pilotprotocol
docs/SIGNATURE-VERIFICATION.md.Testing
Live-socket broker tests (CallWithOrigin delivers, forged cross-app origin stripped, gates still apply), appkit middleware + limiter tests with injected clock, JSON wire-compat (omitempty) round-trips. Full suite green incl. -race.
🤖 Generated with Claude Code