MSC2530: Body field as media caption#2530
Merged
Merged
Conversation
turt2live
added
kind:feature
uhoreg
reviewed
May 8, 2020
auscompgeek
reviewed
May 8, 2020
Comment on lines
+37
to
+38
| name. To avoid this problem, we could require that `body` and `filename` must | ||
| be different for `body` to be interpreted as a caption. |
Contributor
There was a problem hiding this comment.
Another thing to note here is that body is required, so the filename is probably a reasonable fallback for body in the event that no description is given.
MurzNN
added a commit
to MurzNN/matrix-spec-proposals
that referenced
this pull request
Nov 27, 2020
MurzNN
added a commit
to MurzNN/matrix-spec-proposals
that referenced
this pull request
Nov 30, 2020
MurzNN
added a commit
to MurzNN/matrix-spec-proposals
that referenced
this pull request
Nov 30, 2020
turt2live
added
the
needs-implementation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
Please use comments on the diff to receive replies. |
Contributor
|
Yeah, sorry, and seems this MSC is ok, so I've commented a diff in the most suitable MSC here: #2529 (comment) |
Collaborator
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
turt2live
added
spec-pr-missing
turt2live
pushed a commit
that referenced
this pull request
Feb 19, 2024
* Proposal to use body field as media caption * Add paragraph about relation-based captions being difficult for bridges * Clarify how to treat body when filename is not present * Refactor proposal text * Fix heading size * Add problem statement * Add links to and quotes from current spec * Adjust wording and quote m.audio body spec * Clarify that m.location and m.sticker are out of scope for this proposal * Add examples and summary of changes * Fix JSON syntax in example
Member
|
Spec PR: matrix-org/matrix-spec#1731 |
turt2live
added
spec-pr-in-review
Member
|
Merged 🎉 |
turt2live
added
merged
This was referenced Feb 27, 2024
28 tasks
1 task
1 task
bnjbvr
pushed a commit
to matrix-org/matrix-rust-sdk
that referenced
this pull request
Mar 19, 2024
Now that there is some support for [MSC2530](matrix-org/matrix-spec-proposals#2530), I gave adding sending captions a try. ( This is my first time with Rust 😄 ) I tried it on Element X with a hardcoded caption and it seems to work well  (It even got forwarded through mautrix-whatsapp and the caption was visible on the Whatsapp side) --- * ffi: Expose filename and formatted body fields for media captions In relevance to MSC2530 * MSC2530: added the ability to send media with captions Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com> * signoff Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com> * fixing the import messup * fix missing parameters in documentation * fix formatting * move optional parameters to the end * more formatting fixes * more formatting fixes * rename url parameter to filename in send_attachment and helpers * fix send_attachment documentation example * move caption and formatted_caption into attachmentconfig * fix formatting * fix formatting * fix formatting (hopefully the last one) * updated stale comments * simplify attachment message comments --------- Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com> Co-authored-by: SpiritCroc <dev@spiritcroc.de>
8 tasks
This was referenced Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Implementations:
Signed-off-by: Tulir Asokan tulir@maunium.net
FCP tickyboxes