MSC2530: added the ability to send media with captions

[surakin]

Now that there is some support for MSC2530, I gave adding sending captions a try. ( This is my first time with Rust 😄 )

I tried it on Element X with a hardcoded caption and it seems to work well

(It even got forwarded through mautrix-whatsapp and the caption was visible on the Whatsapp side)

• Public API changes documented in changelogs (optional)

Signed-off-by: Marco Alvarez surakin@gmail.com

[codecov]

Codecov Report

Attention: Patch coverage is 37.50000% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 83.64%. Comparing base (876d323) to head (9f89e2d).
Report is 14 commits behind head on main.

❗ Current head 9f89e2d differs from pull request most recent head 58529c3. Consider uploading reports for the commit 58529c3 to get more accurate results

Files	Patch %	Lines
crates/matrix-sdk/src/media.rs	39.13%	14 Missing ⚠️
crates/matrix-sdk/src/encryption/mod.rs	0.00%	11 Missing ⚠️
crates/matrix-sdk-ui/src/timeline/futures.rs	0.00%	3 Missing ⚠️
crates/matrix-sdk/src/attachment.rs	50.00%	3 Missing ⚠️
crates/matrix-sdk/src/room/mod.rs	57.14%	3 Missing ⚠️
crates/matrix-sdk-ui/src/timeline/mod.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3226      +/-   ##
==========================================
- Coverage   83.67%   83.64%   -0.03%     
==========================================
  Files         236      236              
  Lines       24398    24415      +17     
==========================================
+ Hits        20414    20421       +7     
- Misses       3984     3994      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zecakeh]

Just a quick review of things that jumped out at me.

The comments usually apply to several identical parts of the code.

[bnjbvr]

Wow, that's really nice, thanks for working on this! I'm way too excited about getting captioned media in all apps 👀

There are a few CI tasks failing. To re-run them at home:

• clippy: cargo xtask ci clippy
• documentation task: cargo test --doc --features docsrs

Happy to take another look when the comments I've posted have been addressed 😊

[surakin]

All green 🎉

[bnjbvr]

Getting there, thanks for the changes! Only a few comments about doc comments, and we should be good to go.

[bnjbvr]

Thanks! Can you edit the original message to include the signoff, as requested in our contribution guidelines, please?

[bnjbvr]

(CI failure is unrelated.)

[bnjbvr]

Thanks a bunch 🙏 Exciting!

[surakin]

Yay! 🎉