Profiles: Add status and call fields to RoomMember and the UI crate's Profile.#6704
Draft
pixlwave wants to merge 8 commits into
Draft
Profiles: Add status and call fields to RoomMember and the UI crate's Profile.#6704pixlwave wants to merge 8 commits into
RoomMember and the UI crate's Profile.#6704pixlwave wants to merge 8 commits into
Conversation
8d9be91 to
9d046d5
Compare
# Conflicts: # bindings/matrix-sdk-ffi/Cargo.toml
ed7f286 to
6966c95
Compare
6966c95 to
07b667b
Compare
07b667b to
b2cf5c6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6704 +/- ##
==========================================
+ Coverage 89.93% 89.96% +0.03%
==========================================
Files 398 398
Lines 111153 111350 +197
Branches 111153 111350 +197
==========================================
+ Hits 99961 100179 +218
+ Misses 7401 7386 -15
+ Partials 3791 3785 -6 ☔ View full report in Codecov by Harness. |
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #6685, this PR reads the stored global profiles and combines the user status fields into the various room member profile types in the SDK.
Requires #6703 (as it uses the same feature).