Profiles: Allow building a sync service with support for the profiles extension.#6726
Conversation
pixlwave
force-pushed
the
doug/enable-profiles-extension
branch
from
3ac56da to
bd965ac
Compare
| /// Required to merge the global `m.status` and `m.call` fields into the | ||
| /// room members and profiles read from the SDK. |
There was a problem hiding this comment.
To be clear during review. This merge part isn't ready yet, but is being handled by #6704.
| debug!("Enabling the profiles extension for the room list sliding sync"); | ||
| builder = builder.with_profiles_extension(assign!( | ||
| http::request::Profiles::default(), | ||
| { enabled: Some(true) } |
There was a problem hiding this comment.
FTR, I've opted not to include the fields filter in here for the moment – it seems worth waiting to see how much data we receive once we have a working backend to test against.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6726 +/- ##
=======================================
Coverage 89.91% 89.92%
=======================================
Files 398 398
Lines 111154 111169 +15
Branches 111154 111169 +15
=======================================
+ Hits 99948 99966 +18
+ Misses 7415 7412 -3
Partials 3791 3791 ☔ View full report in Codecov by Harness. |
pixlwave
changed the title
| share_pos: bool, | ||
| connection_id: &str, | ||
| timeline_limit: u32, | ||
| profiles_extension: bool, |
There was a problem hiding this comment.
Not terribly happy with how many arguments we now have here, but ok.
|
Thank you! 🎉 |
2 participants
Follow-up to #6685, this PR adds support for building a sync service with the profiles extension enabled.
Signed-off-by: