Profiles: Add status and call fields to room heroes.#6733
Draft
pixlwave wants to merge 2 commits into
Draft
Conversation
pixlwave
changed the title
pixlwave
force-pushed
the
doug/hero-user-status
branch
from
a614a6a to
3eba4d0
Compare
pixlwave
commented
Jul 8, 2026
|
|
||
| /// A [`RoomHero`] augmented with the user's global profile fields. | ||
| #[derive(Clone, Debug, PartialEq)] | ||
| pub struct RoomHeroWithProfile { |
Member
Author
There was a problem hiding this comment.
Claude kept trying to convince me to use RoomHero with a #[serde(skip)] on the profile fields but that felt all kinds of wrong to me so I settled on this route with distinct types for storage vs dto.
Happy to change if this isn't desirable though.
pixlwave
force-pushed
the
doug/hero-user-status
branch
from
3eba4d0 to
1b13b45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #6704 and makes the same changes for Room Heroes. I've done this one separately as this PR makes
Room::heroes()async and changes the return type so I'm less confident of the changes and don't want to block the previous one from being merged on a discussion about heroes.