GH-50670: [Release][Dev] Fix only shellcheck SC2086 errors in the dev directory

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

Fix only ShellCheck SC2086 errors in the dev directory.

• SC2086: Double quote to prevent globbing and word splitting.

shellcheck dev/release/post-01-tag.sh

In dev/release/post-01-tag.sh line 34:
git tag -a ${release_tag} ${release_candidate_tag} -m "[Release] Apache Arrow Release ${version}"
           ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                          ^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
git tag -a "${release_tag}" "${release_candidate_tag}" -m "[Release] Apache Arrow Release ${version}"


In dev/release/post-01-tag.sh line 35:
git push upstream ${release_tag}
                  ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
git push upstream "${release_tag}"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

• SC2086: Quote variables.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [Release][Dev] Fix only ShellCheck SC2086 errors in the dev directory #50670

[github-actions]

⚠️ GitHub issue #50670 has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

The remaining ShellCheck fixes in the ci directory are all R-related, and I’m waiting for the CI fixes.

In the meantime, I created this PR for the straightforward fixes in the dev directory.

Remaining files in the ci directory.

• ci/scripts/r_deps.sh: SC2006 SC2027 SC2086 SC2223
• ci/scripts/r_docker_configure.sh: SC2006 SC2046 SC2086 SC2223
• ci/scripts/r_install_system_dependencies.sh: SC2006 SC2223
• ci/scripts/r_sanitize.sh: SC2086 SC2155 SC2223
• ci/scripts/r_test.sh: SC1091 SC2086 SC2223
• ci/scripts/r_valgrind.sh: SC2046 SC2086 SC2223
• ci/scripts/r_windows_build.sh: SC2011 SC2034 SC2035 SC2046 SC2086 SC2155 SC2223

[kou]

+1

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 986641f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.