GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh by hiroyuki-sato · Pull Request #50610 · apache/arrow

hiroyuki-sato · 2026-07-23T00:42:22Z

Rationale for this change

This is the sub issue #44748.

SC2027: The surrounding quotes actually unquote this. Remove or escape them.
SC2086: Double quote to prevent globbing and word splitting.
SC2223: This default assignment may cause DoS due to globbing. Quote it.

shellcheck ci/scripts/r_deps.sh

In ci/scripts/r_deps.sh line 21:
: ${R_BIN:=R}
  ^---------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/r_deps.sh line 23:
: ${R_PRUNE_DEPS:=FALSE}
  ^--------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/r_deps.sh line 24:
R_PRUNE_DEPS=`echo $R_PRUNE_DEPS | tr '[:upper:]' '[:lower:]'`
             ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
R_PRUNE_DEPS=$(echo "$R_PRUNE_DEPS" | tr '[:upper:]' '[:lower:]')


In ci/scripts/r_deps.sh line 26:
: ${R_DUCKDB_DEV:=FALSE}
  ^--------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/r_deps.sh line 27:
R_DUCKDB_DEV=`echo $R_DUCKDB_DEV | tr '[:upper:]' '[:lower:]'`
             ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
R_DUCKDB_DEV=$(echo "$R_DUCKDB_DEV" | tr '[:upper:]' '[:lower:]')


In ci/scripts/r_deps.sh line 31:
pushd ${source_dir}
      ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
pushd "${source_dir}"


In ci/scripts/r_deps.sh line 33:
if [ ${R_PRUNE_DEPS} = "true" ]; then
     ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
if [ "${R_PRUNE_DEPS}" = "true" ]; then


In ci/scripts/r_deps.sh line 46:
${R_BIN} -e "options(warn=2); install.packages('remotes'); remotes::install_cran(c('glue', 'rcmdcheck', 'sys')); remotes::install_deps(INSTALL_opts = '"${INSTALL_ARGS}"')"
                                                                                                                                                        ^-------------^ SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.
                                                                                                                                                        ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
${R_BIN} -e "options(warn=2); install.packages('remotes'); remotes::install_cran(c('glue', 'rcmdcheck', 'sys')); remotes::install_deps(INSTALL_opts = '""${INSTALL_ARGS}""')"


In ci/scripts/r_deps.sh line 49:
if [ ${R_DUCKDB_DEV} == "true" ]; then
     ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
if [ "${R_DUCKDB_DEV}" == "true" ]; then


In ci/scripts/r_deps.sh line 55:
${R_BIN} -e "remotes::install_deps(dependencies = TRUE, INSTALL_opts = '"${INSTALL_ARGS}"')"
                                                                         ^-------------^ SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.
                                                                         ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
${R_BIN} -e "remotes::install_deps(dependencies = TRUE, INSTALL_opts = '""${INSTALL_ARGS}""')"

For more information:
  https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause...

What changes are included in this PR?

SC2027: Remove redundant quotes.
SC2086: Quote variable expansions.
SC2223: Quote default variable assignments.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh #50609

github-actions · 2026-07-23T00:42:48Z

⚠️ GitHub issue #50609 has been automatically assigned in GitHub to PR creator.

kou · 2026-07-23T02:31:42Z

@github-actions crossbow submit -g r

github-actions · 2026-07-23T02:34:55Z

Revision: 48a4a03

Submitted crossbow builds: ursacomputing/crossbow @ actions-a93615c8b7

Task	Status
r-binary-packages
r-recheck-most
test-r-alpine-linux-cran
test-r-arrow-backwards-compatibility
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-fedora-clang
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-offline-maximal
test-r-ubuntu-22.04
test-r-versions
test-r-wasm

hiroyuki-sato · 2026-07-23T06:38:59Z

@github-actions crossbow submit -g r

github-actions · 2026-07-23T06:42:14Z

Revision: 85f2b3e

Submitted crossbow builds: ursacomputing/crossbow @ actions-47fe7ddf85

Task	Status
r-binary-packages
r-recheck-most
test-r-alpine-linux-cran
test-r-arrow-backwards-compatibility
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-fedora-clang
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-offline-maximal
test-r-ubuntu-22.04
test-r-versions
test-r-wasm

kou · 2026-07-24T02:20:32Z

Let's wait for #50587 before we merge this because the current R related CI jobs are broken.

hiroyuki-sato · 2026-07-24T08:28:09Z

Thanks I got it.

hiroyuki-sato · 2026-07-24T12:31:42Z

Since #47404 also modifies .pre-commit-config.yaml, there may be a merge conflict if either PR is merged first. If that happens, I'll rebase this PR again.

hiroyuki-sato · 2026-07-24T12:36:15Z

#47404 has been merged, so I rebased this PR.

hiroyuki-sato · 2026-07-24T12:38:16Z

@github-actions crossbow submit -g r

raulcd · 2026-07-24T12:38:38Z

    hooks:
      - id: shellcheck
        alias: shell
        # TODO: Remove this when we fix all lint failures


from my understanding we are close to having this. Is the idea to have a follow up and remove this list afterwards. I am unsure if there has been new shell scripts created since this list was built.

@raulcd

Once I fix the remaining six files in ci/scripts, we should be able to remove that part.

ci/scripts/r_docker_configure.sh: SC2006 SC2046 SC2086 SC2223

ci/scripts/r_install_system_dependencies.sh: SC2006 SC2223

ci/scripts/r_sanitize.sh: SC2086 SC2155 SC2223

ci/scripts/r_test.sh: SC1091 SC2086 SC2223

ci/scripts/r_valgrind.sh: SC2046 SC2086 SC2223

ci/scripts/r_windows_build.sh: SC2011 SC2034 SC2035 SC2046 SC2086 SC2155 SC2223

We’re almost there 😄

hiroyuki-sato · 2026-07-24T23:39:12Z

@github-actions crossbow submit -g r

hiroyuki-sato · 2026-07-24T23:39:47Z

@kou @raulcd Thank you for your comment. rebased

github-actions · 2026-07-24T23:42:16Z

Revision: 11523fd

Submitted crossbow builds: ursacomputing/crossbow @ actions-b355b52d7d

Task	Status
r-binary-packages
r-recheck-most
test-r-alpine-linux-cran
test-r-arrow-backwards-compatibility
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-fedora-clang
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-offline-maximal
test-r-ubuntu-22.04
test-r-versions
test-r-wasm

hiroyuki-sato · 2026-07-25T12:21:46Z

I’ll rebase after #50636 is resolved.

hiroyuki-sato · 2026-07-25T14:57:08Z

rebase after #50633 is merged.

hiroyuki-sato · 2026-07-25T14:57:42Z

@github-actions crossbow submit -g r

github-actions · 2026-07-25T15:01:31Z

Revision: e6fe69a

Submitted crossbow builds: ursacomputing/crossbow @ actions-6a5ff9aa9c

Task	Status
r-binary-packages
r-recheck-most
test-r-alpine-linux-cran
test-r-arrow-backwards-compatibility
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-fedora-clang
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-offline-maximal
test-r-ubuntu-22.04
test-r-versions
test-r-wasm

hiroyuki-sato · 2026-07-27T05:23:42Z

I’m not sure whether this is related, but I’ll rebase this PR after #50651 is merged just in case.

hiroyuki-sato · 2026-07-29T08:12:19Z

Rebased after #50671 is merged.

tadeja · 2026-07-30T08:06:01Z

I’m not sure whether this is related, but I’ll rebase this PR after #50651 is merged just in case.

@hiroyuki-sato #50705 was merged instead of #50651, test-r-macos-as-cran should pass after rebase.

…eps.sh

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

…eps.sh

hiroyuki-sato · 2026-07-31T03:10:20Z

@tadeja Thank you for your comment. Rebased

hiroyuki-sato · 2026-07-31T03:10:38Z

@github-actions crossbow submit -g r

github-actions · 2026-07-31T03:13:50Z

Revision: b98fafc

Submitted crossbow builds: ursacomputing/crossbow @ actions-55c8e3be77

Task	Status
r-binary-packages
r-recheck-most
test-r-alpine-linux-cran
test-r-arrow-backwards-compatibility
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-fedora-clang
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-offline-maximal
test-r-ubuntu-22.04
test-r-versions
test-r-wasm

hiroyuki-sato · 2026-07-31T15:02:47Z

r-recheck-most was the only check that failed.

I’m not sure what r-recheck-most is, but it looks like other PRs are also failing. For example:
#50633 (comment)

kou

+1

hiroyuki-sato requested review from assignUser, jonkeane, kou and raulcd as code owners July 23, 2026 00:42

github-actions Bot added the awaiting review Awaiting review label Jul 23, 2026

kou added the CI: Extra: R Run extra R CI label Jul 23, 2026

kou reviewed Jul 23, 2026

View reviewed changes

Comment thread ci/scripts/r_deps.sh Outdated

github-actions Bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting review Awaiting review awaiting changes Awaiting changes labels Jul 23, 2026

github-actions Bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jul 24, 2026

hiroyuki-sato mentioned this pull request Jul 24, 2026

GH-47402: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh #47403

Merged

hiroyuki-sato force-pushed the topic/shellcheck-r_deps branch from 85f2b3e to fab7f57 Compare July 24, 2026 12:34

github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jul 24, 2026

raulcd reviewed Jul 24, 2026

View reviewed changes

github-actions Bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jul 24, 2026

github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jul 24, 2026

hiroyuki-sato force-pushed the topic/shellcheck-r_deps branch from 11523fd to e6fe69a Compare July 25, 2026 14:54

hiroyuki-sato force-pushed the topic/shellcheck-r_deps branch from e6fe69a to 48de5e9 Compare July 29, 2026 08:10

hiroyuki-sato and others added 4 commits July 31, 2026 12:08

apacheGH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_d…

5142ad9

…eps.sh

Update ci/scripts/r_deps.sh

5175de9

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

apacheGH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_d…

393e680

…eps.sh

apacheGH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_d…

b98fafc

…eps.sh

hiroyuki-sato force-pushed the topic/shellcheck-r_deps branch from 48de5e9 to b98fafc Compare July 31, 2026 03:08

kou approved these changes Jul 31, 2026

View reviewed changes

github-actions Bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jul 31, 2026

kou merged commit a947bc4 into apache:main Jul 31, 2026
49 checks passed

kou removed the awaiting merge Awaiting merge label Jul 31, 2026

kou mentioned this pull request Jul 31, 2026

[CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh #50609

Closed

hiroyuki-sato deleted the topic/shellcheck-r_deps branch August 1, 2026 04:33

Uh oh!

Conversation

hiroyuki-sato commented Jul 23, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

kou commented Jul 23, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

hiroyuki-sato commented Jul 23, 2026

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

kou commented Jul 24, 2026

Uh oh!

hiroyuki-sato commented Jul 24, 2026

Uh oh!

hiroyuki-sato commented Jul 24, 2026

Uh oh!

hiroyuki-sato commented Jul 24, 2026

Uh oh!

hiroyuki-sato commented Jul 24, 2026

Uh oh!

raulcd Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

hiroyuki-sato Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

hiroyuki-sato commented Jul 24, 2026

Uh oh!

hiroyuki-sato commented Jul 24, 2026

Uh oh!

github-actions Bot commented Jul 24, 2026

Uh oh!

hiroyuki-sato commented Jul 25, 2026

Uh oh!

hiroyuki-sato commented Jul 25, 2026

Uh oh!

hiroyuki-sato commented Jul 25, 2026

Uh oh!

github-actions Bot commented Jul 25, 2026

Uh oh!

hiroyuki-sato commented Jul 27, 2026

Uh oh!

hiroyuki-sato commented Jul 29, 2026

Uh oh!

tadeja commented Jul 30, 2026

Uh oh!

hiroyuki-sato commented Jul 31, 2026

Uh oh!

hiroyuki-sato commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

hiroyuki-sato commented Jul 31, 2026

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hiroyuki-sato commented Jul 23, 2026 •

edited by github-actions Bot

Loading