Add a starting page for page list block's hierarchy#45861
Merged
Conversation
|
|
Contributor
Author
|
I can’t decide how the UX should feel?
|
draganescu
added
Needs Design Feedback
|
Size Change: +869 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
Contributor
|
I have had a bit on my table so haven't been able to follow along with this effort as much as I liked, hopefully my time should clear up soon. Can you expand on how to best test this and what you'd like feedback on? Is it the "Root page" panel in the inspector? Details
|
Contributor
Author
|
@jasmussen I added a proper description to the PR. Also went the "add a control to the inspector" route and following @scruffian 's suggestion reused the combobox control we have on the page settings inspector. Hopefully this is an intuitive UX. LMK! |
Contributor
|
Oh that's cool, thanks for the video. Just from a glance this seems useful (I know that my friend @mkaz will appreciate this). If he has time, I'd love a glance by @SaxonF. I think we can refine the verbiage a bit. Instead of this:
... how about:
Perhaps a wee bit compressed, but just trying to strike a balance between simpler terms and clarity. What do you think? |
draganescu
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar,
ryanwelcher and
tellthemachines
as code owners
scruffian
reviewed
Nov 21, 2022
scruffian
reviewed
Nov 21, 2022
scruffian
reviewed
Nov 21, 2022
scruffian
reviewed
Nov 21, 2022
scruffian
reviewed
Nov 21, 2022
scruffian
reviewed
Nov 21, 2022
scruffian
reviewed
Nov 21, 2022
scruffian
reviewed
Nov 21, 2022
scruffian
reviewed
Nov 21, 2022
scruffian
reviewed
Nov 21, 2022
scruffian
reviewed
Nov 21, 2022
scruffian
reviewed
Nov 21, 2022
scruffian
reviewed
Nov 21, 2022
scruffian
approved these changes
Nov 21, 2022
scruffian
left a comment
scruffian
left a comment
Contributor
There was a problem hiding this comment.
This is great. I think you can merge once we change root to parent everywhere!
1 task
This was referenced Nov 29, 2022
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR adds the ability to the Page List block to only render a subset of the page hierarchy.
Why?
How?
Set up a
rootPageIDattribute for the Page List block.Testing Instructions
Screenshots or screencast
page-list-root.mp4
To do