Fix page list parent page setting#46122
Closed
draganescu wants to merge 1 commit into
Closed
Conversation
draganescu
added
[Type] Bug
|
Size Change: +6 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Contributor
Author
Contributor
|
We took a different approach here, see #46165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a bug that appeared when merging #45861 and #45776 into trunk. Independently they worked but on conflict resolution some code is not ported correctly.
Why?
To fix a bug where parent page selection is not reflected in the editor, but takes effect when the page list block is rendered.
How?
Adds parent page ID to be the starting point when building the block template made of page list item blocls.
Testing Instructions
Screenshots or screencast
page-list-bug.mp4
To do