Skip to content

Feat/termux install path, bug fixes termux#9846

Closed
adybag14-cyber wants to merge 137 commits into
NousResearch:mainfrom
adybag14-cyber:feat/termux-install-path
Closed

Feat/termux install path, bug fixes termux#9846
adybag14-cyber wants to merge 137 commits into
NousResearch:mainfrom
adybag14-cyber:feat/termux-install-path

Conversation

@adybag14-cyber

Copy link
Copy Markdown
Contributor

Screenshot_20260414_213141
Screenshot_Termux_20260414_213133

What does this PR do?

It fixes the hermes dashboard command on termux

Related Issue

The issue is open on discord
Fixes #
Hermes dashboard is fixed

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)

Changes Made

  • apologies for contaminated bug fix the Hermes android app native co tooling and documents and also build scripts and recipes are all in this pr please salvage the latest commit it has the Hermes dashboard bug fix for termux users.

How to Test

  1. Check screenshots

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

teknium1 pushed a commit that referenced this pull request Apr 14, 2026
Refactor browser tool PATH construction to include Termux directories
(/data/data/com.termux/files/usr/bin, /data/data/com.termux/files/usr/sbin)
so agent-browser and npx are discoverable on Android/Termux.

Extracts _browser_candidate_path_dirs() and _merge_browser_path() helpers
to centralize PATH construction shared between _find_agent_browser() and
_run_browser_command(), replacing duplicated inline logic.

Also fixes os.pathsep usage (was hardcoded ':') for cross-platform correctness.

Cherry-picked from PR #9846.
teknium1 pushed a commit that referenced this pull request Apr 14, 2026
Refactor browser tool PATH construction to include Termux directories
(/data/data/com.termux/files/usr/bin, /data/data/com.termux/files/usr/sbin)
so agent-browser and npx are discoverable on Android/Termux.

Extracts _browser_candidate_path_dirs() and _merge_browser_path() helpers
to centralize PATH construction shared between _find_agent_browser() and
_run_browser_command(), replacing duplicated inline logic.

Also fixes os.pathsep usage (was hardcoded ':') for cross-platform correctness.

Cherry-picked from PR #9846.
@adybag14-cyber adybag14-cyber force-pushed the feat/termux-install-path branch from 7f385fa to 5db13e8 Compare April 15, 2026 21:11
@adybag14-cyber adybag14-cyber force-pushed the feat/termux-install-path branch from 6d966c3 to 6440675 Compare April 18, 2026 22:38
@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard labels Apr 26, 2026
ulasbilgen pushed a commit to ulasbilgen/hermes-adhd-agent that referenced this pull request May 1, 2026
Refactor browser tool PATH construction to include Termux directories
(/data/data/com.termux/files/usr/bin, /data/data/com.termux/files/usr/sbin)
so agent-browser and npx are discoverable on Android/Termux.

Extracts _browser_candidate_path_dirs() and _merge_browser_path() helpers
to centralize PATH construction shared between _find_agent_browser() and
_run_browser_command(), replacing duplicated inline logic.

Also fixes os.pathsep usage (was hardcoded ':') for cross-platform correctness.

Cherry-picked from PR NousResearch#9846.
aj-nt pushed a commit to aj-nt/hermes-agent that referenced this pull request May 1, 2026
Refactor browser tool PATH construction to include Termux directories
(/data/data/com.termux/files/usr/bin, /data/data/com.termux/files/usr/sbin)
so agent-browser and npx are discoverable on Android/Termux.

Extracts _browser_candidate_path_dirs() and _merge_browser_path() helpers
to centralize PATH construction shared between _find_agent_browser() and
_run_browser_command(), replacing duplicated inline logic.

Also fixes os.pathsep usage (was hardcoded ':') for cross-platform correctness.

Cherry-picked from PR NousResearch#9846.
@adybag14-cyber adybag14-cyber force-pushed the feat/termux-install-path branch 11 times, most recently from 89b75a2 to 71f5705 Compare May 6, 2026 12:46
- keep API/access-token, OAuth device-code, and session-token flows distinct
- add explicit third interactive path for session tokens
- persist and resolve pool-backed chatgpt-web session tokens
- cover interactive selection and runtime resolution with tests
- add a dedicated 'hermes auth browser chatgpt-web' command
- launch a Termux-owned Chromium session under Termux:X11 with DevTools enabled
- capture __Secure-next-auth.session-token and store the resulting Hermes credential
- cover parser and bootstrap flow with targeted tests
- expose the Termux browser bootstrap as option 4 in interactive chatgpt-web auth
- route option 4 directly to the browser bootstrap command
- cover the interactive menu path with tests
@adybag14-cyber adybag14-cyber force-pushed the feat/termux-install-path branch from ec88d25 to fb3cb8c Compare May 6, 2026 13:42
@ethernet8023

Copy link
Copy Markdown
Collaborator

merged in #9927

02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
Refactor browser tool PATH construction to include Termux directories
(/data/data/com.termux/files/usr/bin, /data/data/com.termux/files/usr/sbin)
so agent-browser and npx are discoverable on Android/Termux.

Extracts _browser_candidate_path_dirs() and _merge_browser_path() helpers
to centralize PATH construction shared between _find_agent_browser() and
_run_browser_command(), replacing duplicated inline logic.

Also fixes os.pathsep usage (was hardcoded ':') for cross-platform correctness.

Cherry-picked from PR NousResearch#9846.
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
Refactor browser tool PATH construction to include Termux directories
(/data/data/com.termux/files/usr/bin, /data/data/com.termux/files/usr/sbin)
so agent-browser and npx are discoverable on Android/Termux.

Extracts _browser_candidate_path_dirs() and _merge_browser_path() helpers
to centralize PATH construction shared between _find_agent_browser() and
_run_browser_command(), replacing duplicated inline logic.

Also fixes os.pathsep usage (was hardcoded ':') for cross-platform correctness.

Cherry-picked from PR NousResearch#9846.
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
Refactor browser tool PATH construction to include Termux directories
(/data/data/com.termux/files/usr/bin, /data/data/com.termux/files/usr/sbin)
so agent-browser and npx are discoverable on Android/Termux.

Extracts _browser_candidate_path_dirs() and _merge_browser_path() helpers
to centralize PATH construction shared between _find_agent_browser() and
_run_browser_command(), replacing duplicated inline logic.

Also fixes os.pathsep usage (was hardcoded ':') for cross-platform correctness.

Cherry-picked from PR NousResearch#9846.
liuchanchen pushed a commit to liuchanchen/hermes-agent that referenced this pull request Jul 3, 2026
Refactor browser tool PATH construction to include Termux directories
(/data/data/com.termux/files/usr/bin, /data/data/com.termux/files/usr/sbin)
so agent-browser and npx are discoverable on Android/Termux.

Extracts _browser_candidate_path_dirs() and _merge_browser_path() helpers
to centralize PATH construction shared between _find_agent_browser() and
_run_browser_command(), replacing duplicated inline logic.

Also fixes os.pathsep usage (was hardcoded ':') for cross-platform correctness.

Cherry-picked from PR NousResearch#9846.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants