Skip to content

fix(browser): unify PATH fallbacks for Termux and Homebrew#5943

Closed
gut-puncture wants to merge 1 commit into
NousResearch:mainfrom
gut-puncture:codex/termux-browser-path-fix
Closed

fix(browser): unify PATH fallbacks for Termux and Homebrew#5943
gut-puncture wants to merge 1 commit into
NousResearch:mainfrom
gut-puncture:codex/termux-browser-path-fix

Conversation

@gut-puncture

Copy link
Copy Markdown

Summary

  • centralize browser PATH fallback assembly so CLI discovery and subprocess execution use the same logic
  • add Termux fallback directories alongside the existing Homebrew/system defaults so npx, node, and grun remain discoverable on Android
  • extend the existing browser PATH tests with Termux regressions while preserving the Homebrew coverage

Fixes #5845.

Testing

  • source venv/bin/activate && pytest tests/tools/test_browser_homebrew_paths.py

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the contribution @gut-puncture! This fix has already landed on main.

Automated hermes-sweeper review

The exact changes you proposed — Termux PATH fallbacks in _SANE_PATH_DIRS, the _browser_candidate_path_dirs() and _merge_browser_path() helpers, and the new test cases — were committed to main on 2026-04-14:

Your analysis was correct and the fix is solid — it just arrived via a parallel path before this PR was merged. The linked issue #5845 can also be closed now that the fix is on main.

@teknium1 teknium1 closed this Apr 27, 2026
@alt-glitch alt-glitch added type/bug Something isn't working tool/browser Browser automation (CDP, Playwright) P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels Apr 30, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #9927 (merged) — same fix: add Termux PATH fallbacks to browser tool.

1 similar comment
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #9927 (merged) — same fix: add Termux PATH fallbacks to browser tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have tool/browser Browser automation (CDP, Playwright) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

browser_tool: _SANE_PATH missing Termux paths breaks browser on Android

3 participants