fix(browser): add termux PATH fallbacks#7603
Closed
adybag14-cyber wants to merge 1 commit into
Closed
Conversation
Contributor
Author
Contributor
|
Thanks for this contribution, @adybag14-cyber! The Termux PATH fix has already landed on Automated hermes-sweeper review found that this PR's changes are already implemented:
All of this landed in commit 56c34ac ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes
browser_toolon Android/Termux by restoring the Termux-specific PATH entries needed byagent-browsersubprocesses.Before this change, browser command discovery and subprocess execution used different fallback PATH logic. The subprocess path rebuild only included Homebrew/system directories, so it dropped Termux paths like
/data/data/com.termux/files/usr/binand/data/data/com.termux/files/usr/sbin. On Android, that breaks theagent-browser→grunhandoff and causes browser commands to fail even when the required binaries are installed.This fix keeps the change minimal and targeted:
Related Issue
Fixes #5845
Type of Change
Changes Made
tools/browser_tool.py_find_agent_browser()to search the merged fallback PATH_run_browser_command()to build subprocess PATH from the same merged helpertests/tools/test_browser_homebrew_paths.py_SANE_PATHnpxdiscovery via Termux fallback dirsHow to Test
agent-browserand its Android runtime dependencies are installed.source /data/data/com.termux/files/home/.hermes/hermes-agent/.venv/bin/activate && python -m pytest tests/tools/test_browser_homebrew_paths.py -q/data/data/com.termux/files/usr/bin.Screenshots / Logs
Targeted validation run:
21 passed in 1.82s@gut-puncture