Skip to content

gnome2.gtksourceview: fix Darwin build#521903

Open
samestep wants to merge 1 commit into
NixOS:masterfrom
samestep:fix-gnome2.gtksourceview
Open

gnome2.gtksourceview: fix Darwin build#521903
samestep wants to merge 1 commit into
NixOS:masterfrom
samestep:fix-gnome2.gtksourceview

Conversation

@samestep

@samestep samestep commented May 19, 2026

Copy link
Copy Markdown
Contributor

ZHF: #516381

This PR fixes the gnome2.gtksourceview package build on aarch64-darwin (broken since #507470 updated autoconf) via the same pattern used by #425784, #426625, and #475284. See this for more context on those historical failures, and see the autoconf 2.73 release notes which mention the autopoint heuristic change that broke this particular package.

This build failure is Darwin-specific because autoreconf only runs on Darwin for this package.

Closes: #522127

Things done

Assisted-by: Codex:gpt-5.5
@samestep samestep added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 19, 2026
@samestep

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review
Commit: d8e818e9f5fb4b614db8b7cef69dc4865843f278


aarch64-darwin

⏩ 5 packages marked as broken and skipped:
  • coq_8_7
  • coq_8_8
  • coq_8_9
  • ocamlPackages.lablgtk-extras
  • ocamlPackages.ocaml_cairo
❌ 3 packages failed to build:
  • heptagon
  • ocamlPackages.zelus-gtk
  • prooftree
✅ 8 packages built:
  • advi
  • glsurf
  • gnome2.gtksourceview
  • ocamlPackages.camlimages
  • ocamlPackages.lablgtk
  • ocamlPackages.ocamlgraph_gtk
  • proverifWithGui
  • satysfi

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels May 19, 2026
@ofborg ofborg Bot added the 6.topic: darwin Running or building packages on Darwin label May 19, 2026
@SuperSandro2000

Copy link
Copy Markdown
Member

I would rather vouche to remove this gnome 2 package entirely.

@samestep samestep mentioned this pull request May 20, 2026
14 tasks
@samestep

Copy link
Copy Markdown
Contributor Author

@SuperSandro2000 sounds good: #522127

@phibkro

phibkro commented May 30, 2026

Copy link
Copy Markdown
Contributor

Built successfully on x86_64-darwin (nix-build -A gnome2.gtksourceview), producing gtksourceview-2.10.5.

For cross-reference, the alternative fix in #523652 (the ACLOCAL_PATH approach) also builds cleanly on x86_64-darwin. So both proposed fixes resolve the failure — which suggests dropping the package (#522127) isn't necessary on build grounds; it's down to which fix is preferred.

Disclosure: build verification performed with an AI agent (Claude Code, claude-opus-4-8) on x86_64-darwin; results reviewed by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. backport release-26.05 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants