gnome2.gtksourceview: resolve missing AM_GNU_GETTEXT_VERSION build failure#523652
Open
xworld21 wants to merge 1 commit into
Open
gnome2.gtksourceview: resolve missing AM_GNU_GETTEXT_VERSION build failure#523652xworld21 wants to merge 1 commit into
xworld21 wants to merge 1 commit into
Conversation
Member
|
Looks like a duplicate of #521903 |
14 tasks
Contributor
|
Built successfully on For cross-reference, the alternative fix in #521903 (the autoreconf approach) also builds cleanly on x86_64-darwin. Both fixes resolve the failure, so dropping the package (#522127) doesn't appear necessary on build grounds — it's a question of which approach maintainers prefer. Disclosure: build verification performed with an AI agent (Claude Code, claude-opus-4-8) on x86_64-darwin; results reviewed by me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve a Darwin build failure due to gettext m4 macros not being picked up.
The normal fix would be to add automake as build input, but gettext puts those files in a nonstandard folder anyway (
share/gettext/m4rather thanshare/aclocal), so we have to modifyACLOCAL_PATHmanually.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.